fix: install unresolved monorepo plugin deps#995
Draft
lttlin wants to merge 1 commit intojackwener:mainfrom
Draft
fix: install unresolved monorepo plugin deps#995lttlin wants to merge 1 commit intojackwener:mainfrom
lttlin wants to merge 1 commit intojackwener:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Monorepo plugin installs currently run
npm install --omit=devonly once at the monorepo root. When a sub-plugin declares its own runtime dependencies but the monorepo does not expose that package through root workspaces, the compiled plugin loads from~/.opencli/monorepos/.../packages/<plugin>/...and crashes at runtime with module resolution errors such asCannot find package 'undici'.Root Cause
The monorepo install lifecycle assumes the root install is always sufficient for every sub-plugin. It never checks whether a sub-plugin's declared runtime dependencies are actually resolvable from that sub-plugin directory before it is finalized and linked.
Fix
Keep the existing root-level install, but add a targeted fallback for monorepo sub-plugins: if a sub-plugin's
dependencies/optionalDependenciesare still unresolved from its own directory after the root install, runnpm install --omit=devin that sub-plugin before finalizing it. This preserves the fast path for workspace monorepos while fixing non-workspace monorepos like the one reported in #722.Validation
npx vitest run src/plugin.test.tsCloses #722