Fix code comment inconsistency and add corresponding tests#139
Open
YichiZhang0613 wants to merge 3 commits intoitsjunetime:mainfrom
Open
Fix code comment inconsistency and add corresponding tests#139YichiZhang0613 wants to merge 3 commits intoitsjunetime:mainfrom
YichiZhang0613 wants to merge 3 commits intoitsjunetime:mainfrom
Conversation
6f443d2 to
67917af
Compare
Author
|
@itsjunetime Hi, sorry for the interruption. Could you please review this PR when you have time? It's been open for two weeks and I'd appreciate any feedback. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment requires that the following conditions should hold: inclusive_min < exclusive_max and inclusive_min <= around <= exclusive_max, so corresponding assertions should be added.
I also add corresponding tests.