Closed
Conversation
изменена 3 лабораторная работа, в которой содержатся ссылки на 1, 2 и 4
mxwrlld
requested changes
Dec 16, 2025
web/webproj4/script.js
Outdated
Comment on lines
28
to
49
| let result; | ||
|
|
||
| switch (operation) { | ||
| case "addition": | ||
| result = num1 + num2; | ||
| break; | ||
| case "subtraction": | ||
| result = num1 - num2; | ||
| break; | ||
| case "multiplication": | ||
| result = num1 * num2; | ||
| break; | ||
| case "division": | ||
| // Проверка деления на ноль | ||
| if (num2 === 0) { | ||
| resultElement.textContent = "Ошибка: деление на ноль"; | ||
| resultElement.className = "error"; | ||
| return; | ||
| } | ||
| result = num1 / num2; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Лучше не совмещать бизнес - логику и изменение DOM - дерева. Разделите на функции. Как минимум, выделите функцию вычисления
web/webproj4/script.js
Outdated
Comment on lines
23
to
24
| resultElement.textContent = "Ошибка: введите оба числа"; | ||
| resultElement.className = "error"; |
There was a problem hiding this comment.
Используется в нескольких местах, также лучше вынести в отдельную функцию
mxwrlld
requested changes
Dec 18, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
Напоминаю о необходимости внесения изменений!
Collaborator
|
Принято |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
все 4 лабораторных работы
изменена 3 лабораторная работа, в которой содержатся ссылки на 1, 2 и 4