Горшенин Дмитрий Лаб. 1 Группа 6511 by dmgorshenin · Pull Request #2 · itsecd/cloud-development

dmgorshenin · 2026-02-13T14:54:20Z

ФИО: Горшенин Дмитрий
Номер группы: 6511
Номер лабораторной: 1
Номер варианта: 4
Краткое описание предметной области: Генератор кредитной заявки
Краткое описание добавленных фич: Добавлен сервис генерации и кэширования кредитных заявок

…аб. роботы В решение добавлены проекты CreditApplication.AppHost (Aspire-хост), CreditApplication.Generator (API генерации кредитных заявок с кэшированием в Redis) и CreditApplication.ServiceDefaults (общие настройки сервисов: логирование, OpenTelemetry, resilience, health checks). Реализована модель заявки, генератор на Bogus, сервис с кэшированием, API-эндпоинт /credit-application.

Copilot

Pull request overview

This pull request implements Lab 1 for a student assignment, creating a microservices-based credit application generator with caching functionality. The solution demonstrates modern .NET 8 development practices including Bogus for data generation, Redis for distributed caching, Serilog for structured logging, OpenTelemetry for observability, and .NET Aspire for orchestration.

Changes:

Implemented a credit application generator service using Bogus to create synthetic credit application data with Russian localization
Added Redis-based distributed caching to improve performance and reduce redundant data generation
Configured .NET Aspire orchestration to manage the generator service, Redis cache, and Blazor WebAssembly client
Set up comprehensive logging and telemetry infrastructure using Serilog and OpenTelemetry

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
README.md	Replaced generic lab instructions with project-specific documentation including architecture diagrams and screenshots
CreditApplication.ServiceDefaults/Extensions.cs	Implemented shared service configuration for logging, OpenTelemetry, health checks, and service discovery
CreditApplication.ServiceDefaults/CreditApplication.ServiceDefaults.csproj	Defined dependencies for Serilog, OpenTelemetry, and Aspire service discovery
CreditApplication.Generator/Services/CreditApplicationGenerator.cs	Core generator using Bogus to create credit applications with locale-specific data
CreditApplication.Generator/Services/CreditApplicationService.cs	Service layer implementing caching logic with IDistributedCache
CreditApplication.Generator/Models/CreditApplicationModel.cs	Data model for credit applications with XML documentation
CreditApplication.Generator/Program.cs	API endpoint configuration with validation, error handling, and CORS
CreditApplication.Generator/CreditApplication.Generator.csproj	Project dependencies including Bogus and Aspire Redis integration
CreditApplication.Generator/appsettings.json	Logging configuration for the generator service
CreditApplication.Generator/appsettings.Development.json	Development-specific logging configuration
CreditApplication.Generator/Properties/launchSettings.json	Launch profiles for local development
CreditApplication.AppHost/Program.cs	Aspire orchestration configuration for Redis and microservices
CreditApplication.AppHost/CreditApplication.AppHost.csproj	Aspire hosting dependencies
CreditApplication.AppHost/appsettings.json	AppHost logging configuration
CreditApplication.AppHost/appsettings.Development.json	Development-specific AppHost configuration
CreditApplication.AppHost/Properties/launchSettings.json	AppHost launch profiles with Aspire dashboard endpoints
CloudDevelopment.sln	Added three new projects to the solution
Client.Wasm/wwwroot/appsettings.json	Updated API endpoint URL to credit application service
Client.Wasm/Properties/launchSettings.json	Updated client port configuration
Client.Wasm/Components/StudentCard.razor	Updated student information and lab details

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

Copilot · 2026-02-13T14:59:09Z

CreditApplication.Generator/Program.cs

+        policy.AllowAnyOrigin()
+              .AllowAnyMethod()
+              .AllowAnyHeader();


The CORS policy allows any origin, method, and header which is insecure for production environments. While this may be acceptable for a development/lab environment, consider restricting CORS to specific origins in production scenarios or documenting this as a development-only configuration.

Suggested change

policy.AllowAnyOrigin()

.AllowAnyMethod()

.AllowAnyHeader();

if (builder.Environment.IsDevelopment())

{

// In development, allow any origin/method/header for ease of testing.

policy.AllowAnyOrigin()

.AllowAnyMethod()

.AllowAnyHeader();

}

else

{

// In production, restrict CORS to specific trusted origins and limit methods/headers as needed.

policy.WithOrigins("https://your-production-frontend.example")

.WithMethods("GET")

.WithHeaders("Content-Type", "Authorization");

}

Copilot · 2026-02-13T14:59:10Z

CreditApplication.Generator/Services/CreditApplicationService.cs

+        {
+            _logger.LogInformation("Credit application {Id} found in cache", id);
+            var cachedApplication = JsonSerializer.Deserialize<CreditApplicationModel>(cachedData);
+            return cachedApplication!;


The deserialized object could be null if the cached JSON is invalid or malformed. The null-forgiving operator (!) suppresses this warning but doesn't handle the case where deserialization returns null. Consider adding explicit null checking and appropriate error handling, or at least returning a fallback value.

Suggested change

return cachedApplication!;

if (cachedApplication is not null)

{

return cachedApplication;

}

_logger.LogWarning(

"Failed to deserialize cached credit application {Id}. Cached data will be ignored and a new application will be generated.",

id);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

danlla · 2026-02-16T10:01:40Z

CreditApplication.Generator/Services/CreditApplicationGenerator.cs

+            .RuleFor(x => x.RequestedAmount, f => Math.Round(f.Random.Decimal(50_000m, 10_000_000m), 2))
+            .RuleFor(x => x.TermInMonths, f => f.Random.Int(6, 360))
+            .RuleFor(x => x.InterestRate, f => Math.Round(f.Random.Double(MinInterestRate, 35.0), 2))
+            .RuleFor(x => x.ApplicationDate, f => GenerateApplicationDate(f))


Есть PastDateOnly

.RuleFor(x => x.ApplicationDate, f => f.Date.PastDateOnly(2))

danlla · 2026-02-16T10:05:23Z

CreditApplication.Generator/Services/CreditApplicationGenerator.cs

+            var applicationDateTime = app.ApplicationDate.ToDateTime(TimeOnly.MinValue);
+            var decisionDateTime = faker.Date.Between(applicationDateTime, DateTime.Today);
+            app.DecisionDate = DateOnly.FromDateTime(decisionDateTime);


Есть BetweenDateOnly

danlla · 2026-02-16T10:09:19Z

CreditApplication.Generator/Services/CreditApplicationService.cs

+        {
+            _logger.LogInformation("Credit application {Id} found in cache", id);
+            var cachedApplication = JsonSerializer.Deserialize<CreditApplicationModel>(cachedData);
+            return cachedApplication!;


Согласен с копилотом, теоретически может быть ситуация, что в кэш запишется null и лучше проверять здесь, если не null, возвращаем, если null идем дальше и генерируем новый объект

danlla · 2026-02-16T10:10:35Z

CreditApplication.Generator/Services/CreditApplicationService.cs

+    private readonly IDistributedCache _cache = cache;
+    private readonly ILogger<CreditApplicationService> _logger = logger;
+
+    private static readonly TimeSpan _cacheExpiration = TimeSpan.FromMinutes(5);


5 лучше вынести в appsettings.json

danlla · 2026-02-16T10:21:18Z

CreditApplication.Generator/Program.cs

+builder.Services.AddCors(options =>
+{
+    options.AddDefaultPolicy(policy =>
+    {
+        policy.AllowAnyOrigin()
+              .AllowAnyMethod()
+              .AllowAnyHeader();
+    });
+});


Здесь копилот тоже прав, но в принципе пока можно так оставить

danlla · 2026-02-16T10:33:45Z

CreditApplication.AppHost/CreditApplication.AppHost.csproj

+    <PackageReference Include="Aspire.Hosting" Version="8.2.2" />
+    <PackageReference Include="Aspire.Hosting.AppHost" Version="8.2.2" />
+    <PackageReference Include="Aspire.Hosting.Redis" Version="8.2.2" />


Лучше апнуть aspire до последней версии доступной на .net 8 - 9.5.2

потому что сейчас у меня не запускается на 8.2.2

вот как примерно будет выглядеть этот файл после:

<Project Sdk="Microsoft.NET.Sdk"> <Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" /> <PropertyGroup> <OutputType>Exe</OutputType> <TargetFramework>net8.0</TargetFramework> <ImplicitUsings>enable</ImplicitUsings> <Nullable>enable</Nullable> </PropertyGroup> <ItemGroup> <PackageReference Include="Aspire.Hosting" Version="9.5.2" /> <PackageReference Include="Aspire.Hosting.AppHost" Version="9.5.2" /> <PackageReference Include="Aspire.Hosting.Redis" Version="9.5.2" /> </ItemGroup> <ItemGroup> <ProjectReference Include="..\CreditApplication.Generator\CreditApplication.Generator.csproj" /> <ProjectReference Include="..\Client.Wasm\Client.Wasm.csproj" /> </ItemGroup> </Project>

danlla · 2026-02-16T10:34:43Z

Client.Wasm/Properties/launchSettings.json

@@ -14,7 +14,7 @@
      "dotnetRunMessages": true,
      "launchBrowser": true,


Возможно стоит поднастроить настройки запуска клиента, чтобы не открывался отдельно браузер с клиентом

danlla · 2026-02-16T10:36:23Z

CreditApplication.Generator/Services/CreditApplicationGenerator.cs

+
+    private static readonly string[] _terminalStatuses = ["Одобрена", "Отклонена"];
+
+    private readonly ILogger<CreditApplicationGenerator> _logger = logger;


Можно эту строчку удалить и везде использовать logger

danlla · 2026-02-16T10:36:52Z

CreditApplication.Generator/Services/CreditApplicationService.cs

+    private readonly CreditApplicationGenerator _generator = generator;
+    private readonly IDistributedCache _cache = cache;
+    private readonly ILogger<CreditApplicationService> _logger = logger;


Аналогично

danlla · 2026-02-16T10:39:41Z

CreditApplication.Generator/Services/CreditApplicationGenerator.cs

+            .FinishWith((f, app) =>
+            {
+                SetStatusDependentFields(f, app);
+            });


Здесь можно немного попроще:

.FinishWith(SetStatusDependentFields);

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T11:45:57Z

CreditApplication.Generator/Services/CreditApplicationService.cs

+            var cachedApplication = JsonSerializer.Deserialize<CreditApplicationModel>(cachedData);
+
+            if (cachedApplication is not null)
+            {
+                return cachedApplication;
+            }
+
+            _logger.LogWarning("Cached data for credit application {Id} deserialized to null, regenerating", id);


JsonSerializer.Deserialize<CreditApplicationModel>(cachedData) can throw (e.g., corrupted/partial cache entry). Right now this will bubble up and turn the request into a 500 instead of regenerating. Consider catching JsonException, logging it, deleting the bad cache key, and then proceeding to generate/cache a fresh value.

Suggested change

var cachedApplication = JsonSerializer.Deserialize<CreditApplicationModel>(cachedData);

if (cachedApplication is not null)

{

return cachedApplication;

}

_logger.LogWarning("Cached data for credit application {Id} deserialized to null, regenerating", id);

try

{

var cachedApplication = JsonSerializer.Deserialize<CreditApplicationModel>(cachedData);

if (cachedApplication is not null)

{

return cachedApplication;

}

_logger.LogWarning("Cached data for credit application {Id} deserialized to null, regenerating", id);

}

catch (JsonException ex)

{

_logger.LogWarning(ex,

"Failed to deserialize cached credit application {Id}. Removing corrupted cache entry and regenerating.",

id);

try

{

await _cache.RemoveAsync(cacheKey, cancellationToken);

}

catch (System.Exception removeEx)

{

_logger.LogError(removeEx,

"Failed to remove corrupted cache entry for credit application {Id}",

id);

}

}

Copilot · 2026-02-16T11:45:58Z

CreditApplication.ServiceDefaults/CreditApplication.ServiceDefaults.csproj

+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.0.0" />


The Microsoft.Extensions.* package versions are inconsistent here (Microsoft.Extensions.Http.Resilience is 9.0.0 while Microsoft.Extensions.ServiceDiscovery is 9.5.2). These packages commonly share dependencies, and mismatched major/minor versions can lead to restore/runtime conflicts. Align them to the same version line (or introduce central package management) to avoid binding issues.

Suggested change

<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.0.0" />

<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.5.2" />

Copilot · 2026-02-16T11:45:58Z

Client.Wasm/Components/StudentCard.razor

-            <UnorderedListItem><Link To="https://puginarug.com/">Ссылка на форк</Link></UnorderedListItem>
+            <UnorderedListItem>Номер <Strong>№1 «Кэширование»</Strong></UnorderedListItem>
+            <UnorderedListItem>Вариант <Strong>№4 «Кредитная заявка»</Strong></UnorderedListItem>
+            <UnorderedListItem>Выполнена <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>


Grammatically this reads as feminine (“Выполнена”), while the sentence is about the work/assignment (“задание/лабораторная”) and is usually phrased as “Выполнено …”. Consider adjusting the wording to avoid the agreement error.

Suggested change

<UnorderedListItem>Выполнена <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>

<UnorderedListItem>Выполнено <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>

dmgorshenin and others added 4 commits February 13, 2026 18:27

Update README.md

e1db504

Очистка кода

c0518fa

Update README.md

90ecc6e

Copilot AI review requested due to automatic review settings February 13, 2026 14:54

github-actions bot added In progress Код в процессе проверки Lab 1 Лабораторная №1. Кэширование labels Feb 13, 2026

github-actions bot requested a review from danlla February 13, 2026 14:54

Copilot started reviewing on behalf of dmgorshenin February 13, 2026 14:54 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Update README.md

8d9edea

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

danlla requested changes Feb 16, 2026

View reviewed changes

dmgorshenin added 2 commits February 16, 2026 15:41

Исправил правки

85e73d2

Merge branch 'main' of https://github.com/dmgorshenin/cloud-development

9e1bd91

dmgorshenin requested review from Copilot and danlla February 16, 2026 11:42

Copilot started reviewing on behalf of dmgorshenin February 16, 2026 11:42 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

Забыл еще _logger убрать

7d74621

		@@ -14,7 +14,7 @@
		"dotnetRunMessages": true,
		"launchBrowser": true,


		private static readonly string[] _terminalStatuses = ["Одобрена", "Отклонена"];

		private readonly ILogger<CreditApplicationGenerator> _logger = logger;

	<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.0.0" />
	<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.5.2" />

	<UnorderedListItem>Выполнена <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>
	<UnorderedListItem>Выполнено <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>

Conversation

dmgorshenin commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants