Continue numerical recoveries and report resolved confinement#494
Merged
Conversation
This was referenced Jul 16, 2026
…ry-accounting-clean
krystophny
enabled auto-merge (squash)
July 17, 2026 06:03
krystophny
disabled auto-merge
July 17, 2026 06:27
krystophny
enabled auto-merge (squash)
July 17, 2026 06:37
krystophny
added a commit
that referenced
this pull request
Jul 17, 2026
## Summary - keep Newton warning recovery bounded; the obsolete unbounded finite-iterate policy from closed PR #495 is not included - recover failed non-SPECTRE symplectic steps through the established adaptive RK path, cap recovery at 10,000 internal steps, and stop repeating identical failed recovery work - reject non-finite, non-local, or out-of-domain RK and symplectic states before they can be committed or mislabeled as physical LCFS losses - retain the reviewed SPECTRE hardening and the independent fixes from PRs #494, #496, #497, and #498 - compare golden outcomes by physical contract: identities, initial invariants, exit status/time, valid resolved endpoints, and strict physical events; completed chaotic survivor phase points may decorrelate ## Validation - full `fo` at `c57f419`: static analysis, build, complete test suite, and lint passed in 304.4 s - focused `test_sympl_testfield` and `test_newton_solver_status` pass - 13 golden-comparator unit tests pass - fresh Albert golden run completed without the former stall; all 32 markers resolved, every endpoint was finite, and mapped final radius stayed in 0.017 to 1.013 - the golden comparison identifies 27 recovered numerical exits and corrects three old physical-loss records whose reference endpoints had radial coordinates of roughly 5e5 to 2e6 PR #495 was closed because its generic policy admitted arbitrarily large finite Newton iterates and produced invalid physical outcomes. This branch was rebuilt without it. The final performance comparison will be rerun without the concurrent large LFS archive upload before merge.
This was referenced Jul 18, 2026
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the production continuation/accounting contract from Newton acceptance policy.
Validated as the base of the stacked branch with the complete
fopipeline.