Draft
Conversation
rimi-itk
force-pushed
the
feature/4268-api-platform-v4-builtin-filters
branch
from
11b9ebb to
5489a8c
Compare
# Conflicts: # CHANGELOG.md
rimi-itk
force-pushed
the
feature/4268-api-platform-v4-builtin-filters
branch
from
5489a8c to
6f7533a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #18 to use built-in Elasticsearch filter.
Important
We'll leave this for now. The current custom filters make some assumptions on entity names and such, and we need more time to resolve this. The custom filters are not very complex, i.e. we don't have a lot of techincal dept hidden in them, and therefore it makes sense (from a security point of view) to postpone a potential cleanup to when/if time – and money – allows putting more effort into this.