Skip to content

Update ec_launchers and pulse_schedule#253

Draft
olivhoenen wants to merge 10 commits into
developfrom
update_ec_launchers_and_ps
Draft

Update ec_launchers and pulse_schedule#253
olivhoenen wants to merge 10 commits into
developfrom
update_ec_launchers_and_ps

Conversation

@olivhoenen
Copy link
Copy Markdown
Collaborator

@olivhoenen olivhoenen commented May 19, 2026

@github-actions
Copy link
Copy Markdown

@olivhoenen
Copy link
Copy Markdown
Collaborator Author

This PR has merged changes from PR#234 and PR#244, in order that @fmpoli68 can test this change in applications. It stays in draft for the moment.

@olivhoenen olivhoenen added the to be tested A PR that needs to be tested in-situ before merging to a production branch label May 19, 2026
@fmpoli68
Copy link
Copy Markdown

fmpoli68 commented Jun 1, 2026

We have started the tests for this branch.

Below are the issues we found.

In the ec_launchers IDS

  1. waveguide
    │ ├── waveguide(i1)/name
    │ ├── waveguide(i1)/description
    │ ├── waveguide(i1)/geometry
    │ │ └──
    │ └── waveguide(i1)/movement(i2)
    │ └──

movement should be removed, since waveguides are fixed.

  1. I lost track of why we removed the mirror_index under beam.
    => please put it back
    It is not clear how to best represent a complex optical path. We need to test with the mirror_index
    ├── beam(i1)/waveguide_index
    │ ├── beam(i1)/source_index
    │ ├── beam(i1)/mirror_index

In the pulse_schedule IDS:

NOTE: I am not sure how many people are using the pulse_schedule. To avoid disruption to these users I propose to create the correct structures, but not delete the existing structures that are incorrectly described (for now).
For example, the following do not belong to the pulse_schedule/ec/beam:
beam/deposition_rho_tor_norm
beam/steering_angle_toroidal
beam/steering_angle_poloidal

Change requested:

  1. please, add deposition_rho_tor_norm under mirror.
    The description should be replaced with the following: "Normalized toroidal flux coordinate at which the main deposition should occur. For tracking a rational surface use a negative value (for example -1.5 or -2.0)".

  2. the polarization should be set in the pulse_schedule (O_mode, X_mode).
    Can we copy here the polarization structure from the ec_launchers
    pulse/ec/beam/polarization
    After testing, we will be able to tell whether we need the full structure. Perhaps here we need only O_mode_fraction, but we will see.

@imbeauf If the above can be implemented in a short time workaround, we can do a number of tests, including algorithms for steering. Then we will come back with a proposal to map which gyrotron is connected where in the pulse_schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to be tested A PR that needs to be tested in-situ before merging to a production branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request for extension] pulse_schedule Request for extension of ec_launchers

3 participants