Update ec_launchers and pulse_schedule#253
Conversation
…lated improvements
…ndex are constant instead of static
…elds following the change of convention IMAS-5174
…e recent evolutions of ec_launchers
|
This PR has merged changes from PR#234 and PR#244, in order that @fmpoli68 can test this change in applications. It stays in draft for the moment. |
|
We have started the tests for this branch. Below are the issues we found. In the ec_launchers IDS
movement should be removed, since waveguides are fixed.
In the pulse_schedule IDS: NOTE: I am not sure how many people are using the pulse_schedule. To avoid disruption to these users I propose to create the correct structures, but not delete the existing structures that are incorrectly described (for now). Change requested:
@imbeauf If the above can be implemented in a short time workaround, we can do a number of tests, including algorithms for steering. Then we will come back with a proposal to map which gyrotron is connected where in the pulse_schedule. |
📚 Documentation preview 📚: https://imas-data-dictionary--253.org.readthedocs.build/en/253/