Force scale ratio if x and y axis have same unit for 1D and 2D plots#80
Open
mfiaudrin-epsyl wants to merge 1 commit into
Open
Force scale ratio if x and y axis have same unit for 1D and 2D plots#80mfiaudrin-epsyl wants to merge 1 commit into
mfiaudrin-epsyl wants to merge 1 commit into
Conversation
mfiaudrin-epsyl
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
Documentation build overview
48 files changed ·
|
There was a problem hiding this comment.
Pull request overview
Adds automatic 1:1 axis scaling for 1D and 2D plots when the relevant axes share the same unit, improving visual comparability for same-unit data.
Changes:
- SimplePlotly: compute a
shouldForceRatiorule and apply Plotlyxaxis.scaleanchor/scaleratioaccordingly. - Heatmap2D: compute a similar
shouldForceRatiorule from coordinate units and apply the same Plotly layout constraint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/src/renderer/components/plot/SimplePlotly.tsx | Adds a same-unit detection rule and conditionally anchors x/y scaling via Plotly layout. |
| frontend/src/renderer/components/plot/Heatmap2D.tsx | Adds a coordinate-unit equality rule and conditionally anchors x/y scaling via Plotly layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+136
| useEffect(() => { | ||
| const coordinateUnit = itemDataGrid.coordinates.find( | ||
| (c) => c.axeIndex === 0, | ||
| )?.unit; | ||
| const allPlotsHaveSameUnit = itemDataGrid.plot.every( | ||
| (plot) => plot.unit === itemDataGrid.plot[0]?.unit, | ||
| ); | ||
| setShouldForceRatio( | ||
| allPlotsHaveSameUnit && coordinateUnit === itemDataGrid.plot[0]?.unit, | ||
| ); | ||
| }, [itemDataGrid.coordinates]); |
Comment on lines
+138
to
+140
| /** | ||
| * Update layout to force ratio are not | ||
| */ |
Comment on lines
+96
to
+104
| useEffect(() => { | ||
| const firstCoordinateUnit = itemDataGrid.coordinates.find( | ||
| (c) => c.axeIndex === 0, | ||
| )?.unit; | ||
| const secondCoordinateUnit = itemDataGrid.coordinates.find( | ||
| (c) => c.axeIndex === 1, | ||
| )?.unit; | ||
| setShouldForceRatio(firstCoordinateUnit === secondCoordinateUnit); | ||
| }, [itemDataGrid.coordinates]); |
Comment on lines
+106
to
+108
| /** | ||
| * Update layout to force ratio are not | ||
| */ |
Contributor
|
Errors encountered when testing this PR are described in #84 (it also affects the Otherwise the square ratio feature works as expected. From our last discussion with the group and @imbeauf, we mentioned that ideally there would be a customization option to allow the user to disable the fixed ratio (fix ratio is good as the default behavior), as well as to enable fixed ratio even if units are not the same in x and y. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature add a rule to display the plots with the the same ratio between x & y axis if they have the same unit.