feat: Helm chart, container image e pipeline CI/CD - #3
Merged
Conversation
- Helm chart in deploy/helm/developers-cms (deployment, service, ingress, secret, PVC media, job migrate + job seed che crea utente e API key) - Dockerfile riscritto: deps con bun, build+runtime su node (glibc, sharp ok), immagine non-standalone con CLI payload per migrate/seed in cluster - Baseline migration completa (CREATE TABLE) al posto delle ALTER-only rotte - CI: test int + e2e, build e push immagine su GHCR, package+push chart Helm OCI
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9772134 | Triggered | Generic Password | f9fb4d9 | .github/workflows/ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa
deploy/helm/developers-cms(deployment, service, ingress, secret, PVC media, job migrate + job seed che crea il primo utente e una API key deterministica per le API in lettura/scrittura).bun.lock), build+runtime su node (glibc →sharpok), immagine non-standalone con CLIpayloadper migrate/seed in cluster.CREATE TABLE) al posto delle migration ALTER-only che fallivano su DB vuoto. Validata in locale su Postgres vuoto..github/workflows/ci.yml): testint+e2e, build e push immagine su GHCR, package+push chart Helm OCI sughcr.io/italia/charts.I values reali test/prod stanno in
k8s-configuration(non in questo repo).Note
eslintè rotto a monte (config) → non incluso come gate./app/media, set API key.