Conversation
…iate. Also fix some typos and make naming consistent
Sorry--I use `vim`.
* A few wording tweaks * Change `scope_association` concept to require that `try_associate` return an `Assoc` rather than "anything that models `scope_association`"; it turns out that concepts can't be recursive * Some formatting tweaks
Add wording for the changes to: * `<execution>`'s synopsis, * the first few paragraphs describing _`associate-data`_, and * the scope concepts. Still need to finish describing the changes to `associate`, and add all the changes for `spawn`, `spawn_future`, `simple_counting_scope`, and `counting_scope`.
Replace references to _`token`_ with _`assoc`_ when computing the `noexcept` clause for _`associate-data`_'s copy constructor.
This finishes the wording for `associate`. Also, I noticed that the standard uses a two-space indent, not four, so I tweaked the formatting to better match the existing text in the latest draft.
I realized I'd missed `operator=` for the `assoc` types, and then realized I could fix it with clever use of `unique_ptr`.
This diff changes from using the block-level edit markers like this:
```
::: add
// additions here
:::
```
to inline edit markers like this:
```
[/* additions here */]{.add}
```
because I think the resulting doc looks nicer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.