v3.5.7 - Optimize StackTrace capture#432
Merged
isoos merged 8 commits intoisoos:masterfrom Oct 2, 2025
Merged
Conversation
- A `ResultStream` that adds a `callerTrace` parameter to the `listen` method.
…esultStream`. - `_PgResultStreamSubscription`: added an optional `callerTrace` parameter to its constructors.
- Optimized `run` and `_closePendingPortals` by reducing `StackTrace` captures.
Contributor
Author
|
With this PR, the 
Detailed: 
Previous ( 
|
Contributor
Author
|
Note, this PR is just reducing unnecessary calls to StackTrace.current |
Owner
|
@gmpassos: I'm sorry, I have missed out this PR, and since then landed a few changes, formatting for new SDK mostly that is affecting this. I'll check it later and try to resolve and also review. |
# Conflicts: # CHANGELOG.md # lib/src/v3/connection.dart # pubspec.yaml
Contributor
Author
|
FYI @isoos, I’ve synced the PR with master. Best regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.5.7
PgSessionBase:_prepareby passing the already capturedStackTraceto_sendAndWaitForQuery.Added
ResultStreamTrace:ResultStreamthat adds acallerTraceparameter to thelistenmethod._BoundStatementnow implementsResultStreamTracerather thanResultStream._PgResultStreamSubscription: added an optionalcallerTraceparameter to its constructors.PreparedStatement:runand_closePendingPortalsby reducingStackTracecaptures.