feat: implement HTTPS for secure website protocol#56
Open
abhisheknanaware wants to merge 1 commit into
Open
Conversation
feat: implement HTTPS for secure website protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request introduces HTTPS support to the server configuration, ensuring secure communication over the network. The following changes have been made:
sslCertPathandsslKeyPathto theserverConfigobject insrc/server/config.jsto specify the paths to the SSL certificate and key files.src/server/server.jsto importhttpsandfsmodules and configure the server to use HTTPS by creating an HTTPS server with the specified SSL options.src/client/App.vueto include logic that redirects users from HTTP to HTTPS, ensuring secure access.package.jsonto includehttpsandexpressas dependencies.Motivation
The primary motivation for this change is to enhance the security of the application by encrypting data transmitted between the client and server. This is particularly important for applications that handle sensitive information, such as login credentials.
How to verify
jesttests intests/config.test.jsto verify that the server configuration includes SSL paths and throws errors if they are missing.jesttests intests/server.test.jsto ensure the HTTPS server is set up correctly and handles missing SSL files appropriately.jestto runtests/AppMounted.test.jsto confirm that the client correctly redirects from HTTP to HTTPS.Ensure that the SSL certificate and key files are correctly placed at the specified paths before starting the server.