Fix bugs in Ionosphere Phase Uncertainty & connected components mask#220
Open
oberonia78 wants to merge 4 commits intoisce-framework:developfrom
Open
Fix bugs in Ionosphere Phase Uncertainty & connected components mask#220oberonia78 wants to merge 4 commits intoisce-framework:developfrom
oberonia78 wants to merge 4 commits intoisce-framework:developfrom
Conversation
xhuang-jpl
approved these changes
Feb 17, 2026
Contributor
xhuang-jpl
left a comment
There was a problem hiding this comment.
LGTM, thank you @oberonia78 , some minor comments.
Comment on lines
+464
to
+468
| if side_coh is None and diff_ms_coh is None: | ||
| raise ValueError( | ||
| "estimate_iono_std requires at least one of " | ||
| "`diff_ms_coh` or `side_coh` to be provided." | ||
| ) |
Contributor
There was a problem hiding this comment.
Can you also use journal log here?
| term1 = f_diff / f0 * nondisp_array | ||
| term2 = f_diff / f1 * disp_array | ||
| diff_unw_coeff = np.round( | ||
| diff_unw_coeff = -1 * np.round( |
Contributor
There was a problem hiding this comment.
where does the -1 come from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in

IonospherePhaseUncertaintyderived from themain_diff_ms_bandmethod.The problem was in
estimate_iono_std, where the division operation was incorrect. The operator / has been replaced with *.In addition, there was a bug in
connected_componentsused during mask building. This issue has also been fixed.