RX Channel Imbalances in EAP#192
Open
rad-eng-59 wants to merge 20 commits intoisce-framework:developfrom
Open
Conversation
rad-eng-59
requested review from
Tyler-g-hudson,
bhawkins,
hb6688 and
hfattahi
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
Some code organization and documentation commentary
| time_delays_sec: np.ndarray | ||
| max_amp_ratio: float | ||
|
|
||
| def __post_init__(self): |
Contributor
There was a problem hiding this comment.
Maybe check the array dtypes here to ensure they're complex/int/float respectively?
Contributor
Author
There was a problem hiding this comment.
Not necessary. Float is a special case of complex if occurs for any reason and thus shall be supported.
Comment on lines
+379
to
+381
| # XXX to avoid unit test failure and old sim L0B | ||
| # a warning will be issued and all values will be set | ||
| # to unity! |
Contributor
There was a problem hiding this comment.
Similar concern to other XXX comments - is this behavior undesirable? Do we intend to change it later?
Contributor
Author
There was a problem hiding this comment.
See my previous response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR computes frequency-dependent polarization-dependent RX channels imbalances and incorporate them into RX DBF process of pattern.py module as part EAP in RSLC workflow.
By adding this feature:
Disclaimer: Not yet fully tested over a pair of L0Bs with phase jump issue!