Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
- Coverage 43.51% 43.41% -0.10%
==========================================
Files 582 582
Lines 24691 24754 +63
Branches 7331 8257 +926
==========================================
+ Hits 10744 10748 +4
- Misses 13897 13949 +52
- Partials 50 57 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListViewItemBaseProps, which more obviously dictate where a particular type of list view can be used.I have currently kept ListView and ListViewCard separate since I couldn't figure out the types, but I see no reason why it shouldn't be possible to specify this with e.g.
layout='card'in the<ListView />. The biggest problem is being able to throw a type error if an instance of ListView had only one layout type (e.g. was typed asListViewItemBaseProps<"item","list">rather than a union).