Skip to content

List view expansion#2080

Open
jacbn wants to merge 4 commits intomainfrom
feature/list-view-expansion
Open

List view expansion#2080
jacbn wants to merge 4 commits intomainfrom
feature/list-view-expansion

Conversation

@jacbn
Copy link
Copy Markdown
Contributor

@jacbn jacbn commented Mar 31, 2026

  • Expands list views to enable support for builder items (though their implementation is not in this PR for better separation);
  • Fixes inconsistencies with where certain props are located in list views;
  • Extracts common types into e.g. ListViewItemBaseProps, which more obviously dictate where a particular type of list view can be used.

I have currently kept ListView and ListViewCard separate since I couldn't figure out the types, but I see no reason why it shouldn't be possible to specify this with e.g. layout='card' in the <ListView />. The biggest problem is being able to throw a type error if an instance of ListView had only one layout type (e.g. was typed as ListViewItemBaseProps<"item","list"> rather than a union).

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 52.20588% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.41%. Comparing base (8657d8b) to head (7418f60).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...c/app/components/elements/list-groups/ListView.tsx 37.93% 54 Missing ⚠️
src/app/components/pages/SubjectOverviewPage.tsx 28.57% 5 Missing ⚠️
...p/components/pages/subjectLandingPageComponents.ts 80.95% 4 Missing ⚠️
src/app/components/pages/MyProgress.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
- Coverage   43.51%   43.41%   -0.10%     
==========================================
  Files         582      582              
  Lines       24691    24754      +63     
  Branches     7331     8257     +926     
==========================================
+ Hits        10744    10748       +4     
- Misses      13897    13949      +52     
- Partials       50       57       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacbn jacbn marked this pull request as ready for review April 2, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant