Refactor Assignment Progress to logically group components#2065
Open
Refactor Assignment Progress to logically group components#2065
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 43.14% 43.16% +0.02%
==========================================
Files 580 581 +1
Lines 24958 24966 +8
Branches 8276 8274 -2
==========================================
+ Hits 10768 10777 +9
- Misses 14133 14139 +6
+ Partials 57 50 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-progress-file-structure [VRT] Update baselines for improvement/assignment-progress-file-structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file structure of the AssignmentProgress group of files is a mess. e.g.
AssignmentProgressIndividualis in the/pages/folder but is not a page itself, it has the same naming scheme asAssignmentProgressGroupdespiteSingleAssignmentProgressbeing its equivalent inAssignmentProgressWrapper, and components likeAssignmentProgressLegendare not grouped to a logically consistent location within these files.This PR does not change the logic of these files (except where purposely mentioned) but changes the structure so it's clear where each component is meant to be.
The important changes are:
/pages/assignment_progressfolder to associate these related pages together inside.AssignmentSummaryCardcomponent to use shared code for the nearly identical Due/Attempted/Completed summary card shown above both a quiz and assignment summary.ResultsTableHeadercomponent to group together the components that are consistently above a result table section (Title/Settings/Key) in each tab/quizzes.