Skip to content

Add "Exact answers only" option to coordinate questions#772

Draft
axlewin wants to merge 5 commits intomainfrom
hotfix/coord-disregard-sf
Draft

Add "Exact answers only" option to coordinate questions#772
axlewin wants to merge 5 commits intomainfrom
hotfix/coord-disregard-sf

Conversation

@axlewin
Copy link
Copy Markdown
Contributor

@axlewin axlewin commented Apr 2, 2026

Adds an option for "Exact answers only" (disregardSignificantFigures) for coordinate questions. This works the same way as it does for numeric questions, i.e. validates that two values are exactly numerically equivalent without considering significant figures.

This enables coordinate questions to be used for cases where different values in the choice need to be given to different significant figures (e.g. (1, 2.34)).

axlewin added 4 commits April 2, 2026 10:59
We now need three different values from the question, so pass the whole question in and get sig figs from it within the helper rather than passing them in separately.
Using the same validation as is used for numeric questions.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.95%. Comparing base (05060c4) to head (23eccee).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...am/cl/dtg/isaac/quiz/IsaacCoordinateValidator.java 72.22% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   39.94%   39.95%           
=======================================
  Files         547      547           
  Lines       23840    23852   +12     
  Branches     2887     2892    +5     
=======================================
+ Hits         9523     9530    +7     
- Misses      13415    13417    +2     
- Partials      902      905    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant