Skip to content

Fix incorrect calculation of local contrast adaption in color edge detection#11

Open
iRi-E wants to merge 1 commit into
iryoku:masterfrom
iRi-E:fix_local_contrast_adaption
Open

Fix incorrect calculation of local contrast adaption in color edge detection#11
iRi-E wants to merge 1 commit into
iryoku:masterfrom
iRi-E:fix_local_contrast_adaption

Conversation

@iRi-E

@iRi-E iRi-E commented Dec 20, 2016

Copy link
Copy Markdown

In SMAAColorEdgeDetectionPS(), the calculations of left-left and top-top deltas are performed as:

    t = abs(C - Cleftleft);

and

    t = abs(C - Ctoptop);

However, these are not differences of neighboring pixels, so should be modified as follows:

    t = abs(Cleft - Cleftleft);

and

    t = abs(Ctop - Ctoptop);

Thanks!

iRi-E added a commit to iRi-E/blender-experiment that referenced this pull request Dec 21, 2016
…tion

This bug came from original GLSL version.
See the corresponding bug report:

iryoku/smaa#11
iRi-E added a commit to iRi-E/smaa-cpp that referenced this pull request Jan 7, 2017
…tion

This bug came from original GLSL version.
See the corresponding bug report:

iryoku/smaa#11
iRi-E added a commit to iRi-E/blender-experiment that referenced this pull request Jan 13, 2017
…tion

This bug came from original GLSL version.
See the corresponding bug report:

iryoku/smaa#11
iRi-E added a commit to iRi-E/blender-experiment that referenced this pull request Jan 26, 2017
…tion

This bug came from original GLSL version.
See the corresponding bug report:

iryoku/smaa#11
jntesteves added a commit to jntesteves/libretro-slang-shaders that referenced this pull request Sep 14, 2021
jntesteves added a commit to jntesteves/libretro-slang-shaders that referenced this pull request Sep 14, 2021
Fix incorrect calculation of local contrast adaption in color edge detection

This is the fix from PR iryoku/smaa#11
jntesteves added a commit to jntesteves/libretro-slang-shaders that referenced this pull request Sep 14, 2021
Fix incorrect calculation of local contrast adaption in color edge detection

This is the fix from PR iryoku/smaa#11
vvv-yeaf added a commit to vvv-yeaf/Torque3D that referenced this pull request Sep 2, 2022
pchome added a commit to pchome/VulkanFX that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant