Skip to content

Fix unused_container propagation#49

Merged
saki7 merged 1 commit into
mainfrom
fix-unused-container-propagation
Feb 24, 2026
Merged

Fix unused_container propagation#49
saki7 merged 1 commit into
mainfrom
fix-unused-container-propagation

Conversation

@saki7
Copy link
Copy Markdown
Member

@saki7 saki7 commented Feb 24, 2026

Compound parsers should accept BOTH unused_type and unused_container_type.

Note that their types are accepted as-is but the values are unconditionally converted to unused_type. This is currently the correct solution because the parsers which need unused_container_type actually converts unused_type to unused_container_type in their parse function. If we instead keep the unused_container instance, some underlying parsers might fail to select the correct overload which relies on unused_type (instead of unused_container_type).

@saki7 saki7 self-assigned this Feb 24, 2026
@saki7 saki7 added the bug Something isn't working label Feb 24, 2026
@cppwarningnotifier
Copy link
Copy Markdown

EnvironmentC++23C++26
x4Clang21Debug✅success✅success
Release✅success✅success
GCC14Debug✅success✅success
Release✅success✅success
MSVC2022Debug✅success✅success
Release✅success✅success
2026Debug✅success✅success
Release✅success✅success

@saki7 saki7 merged commit e6f1385 into main Feb 24, 2026
66 of 68 checks passed
@saki7 saki7 deleted the fix-unused-container-propagation branch February 24, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant