Improve game interaction handling#137
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make Discord interaction handling more resilient during long-running gameplay (especially timeouts), reducing failures related to expired/invalid interaction tokens and improving logging around unexpected runtime errors.
Changes:
- Run
Game.start()in a background task from the start-game interaction to avoid blocking the interaction flow. - Add a fallback in
Game.send()to post to the channel when an interaction respond fails with “Invalid Webhook Token” (401 / code 50027). - Add an async unit test covering the invalid-webhook-token fallback behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/test_core.py |
Adds an async test verifying Game.send() falls back to channel.send() on invalid interaction webhook token. |
eggsplode/ui/start.py |
Starts the game in a background task and logs unhandled exceptions during game execution. |
eggsplode/core.py |
Wraps interaction response sending with handling for invalid webhook token and falls back to sending via the channel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com
Makes timeout and interaction handlign stabler and adds more exception handling and logging.
Should address several recent "Unauthorized (error code: 50027): Invalid Webhook Token" messages in the logs.