fix: make last batch operation take effect#150
Merged
Conversation
When adding Put and Delete operations to a batch, for the same key, make the last operation be the one to take effect. Put and Delete for same key: - Delete after Put: Commit removes Put and deletes item from datastore. - Put after Delete: Put removes Delete from batch and adds Put. Closes #49
lidel
approved these changes
Jun 24, 2026
lidel
left a comment
lidel
left a comment
Member
There was a problem hiding this comment.
LGTM, feels correct, thanks for locking this down with docs and test (pushed small typo fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding Put and Delete operations to a batch, for the same key, make the last operation be the one to take effect.
Put and Delete for same key:
Closes #49