Skip to content
Merged

prep #75

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# accessibility (development version)
# accessibility 1.6.0

## New features

- `cumulative_interval()` has a new argument `fill_missing_ids`. When `TRUE`
(the default), ids that reach no opportunity are kept with accessibility 0,
as in `cumulative_cutoff()`.

## Breaking changes
## Major changes

- Accessibility functions now treat `NA` opportunity, demand and supply
values, and `travel_matrix` ids missing from `land_use_data`, as 0.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ remotes::install_github("ipea/accessibility")
## Usage

This section aims to present a very brief overview of some of the
packages’ features. Fore more details please read the vignettes:
package’s features. For more details please read the vignettes:

- [Introduction to **accessibility**: calculating accessibility
measures](https://ipea.github.io/accessibility/articles/accessibility.html)
Expand Down Expand Up @@ -71,7 +71,7 @@ cum_cutoff <- cumulative_cutoff(
)
head(cum_cutoff)
#> id jobs
#> <char> <int>
#> <char> <num>
#> 1: 89a881a5a2bffff 14561
#> 2: 89a881a5a2fffff 29452
#> 3: 89a881a5a67ffff 16647
Expand Down Expand Up @@ -148,8 +148,8 @@ poverty

## Related work:

- [r5r](https://github.com/ipea/r5r): Rapid Realistic Routing with R5
in R
- [r5r](https://github.com/ipea/r5r): Rapid Realistic Routing with R5 in
R
- [tracc](https://github.com/jamaps/tracc): Transport accessibility
measures in Python
- [access](https://access.readthedocs.io/en/latest/): Spatial Access for
Expand Down
4 changes: 2 additions & 2 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"codeRepository": "https://github.com/ipea/accessibility",
"issueTracker": "https://github.com/ipea/accessibility/issues",
"license": "https://spdx.org/licenses/MIT",
"version": "1.5.0.9000",
"version": "1.6.0",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down Expand Up @@ -255,7 +255,7 @@
},
"SystemRequirements": null
},
"fileSize": "3154.045KB",
"fileSize": "3239.651KB",
"releaseNotes": "https://github.com/ipea/accessibility/blob/main/NEWS.md",
"readme": "https://github.com/ipea/accessibility/blob/main/README.md",
"contIntegration": ["https://github.com/ipea/accessibility/actions", "https://app.codecov.io/gh/ipea/accessibility?branch=main"],
Expand Down
32 changes: 18 additions & 14 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
── R CMD check results ──────────────────────────────── accessibility 2.0.0 ────
Duration: 1m 57.1s
## Submission

0 errors ✔ | 0 warnings ✔ | 0 notes ✔
This is a minor release (1.6.0). It fixes several bugs (notably in
`constrained_accessibility()` with grouped data and multiple decay values,
and integer overflow with large counts) and includes a few documented
breaking changes in edge cases (e.g. `NA` opportunities are now treated as 0
and integer inputs return doubles). See NEWS.md.

## R CMD check results

## New features
0 errors | 0 warnings | 0 notes

- New function `constrained_accessibility()`, which implements the family of
constrained accessibility measures proposed in \url{https://doi.org/10.1371/journal.pone.0335951}
## Test environments

## Minor changes
- local: Windows 11, R 4.5.1
- win-builder: R-devel, R-release (TODO)
- GitHub Actions: ubuntu-latest (devel, release, oldrel), macOS-latest
(release), windows-latest (release) (TODO: confirm green)

- The function `fgt_poverty()` has a new argument `poor_below_threshold`. when
set to `TRUE` (default,) the observations below the poverty line are considered
to be poor. This is the correct approach for primal accessibility measures (e.g.
cumulative accessibility). If `FALSE`, then observations above the poverty line
are considered to be poor. This is the correct approach for dual accessibility
measures (e.g. travel time to the closest facility). When set to `FALSE`, FGT 1
and 2 do not have an upper bound.
## Reverse dependencies

We checked the one reverse dependency, r5r (Suggests). It only calls
`cumulative_cutoff()` in a vignette chunk that is not evaluated, so it is not
affected by this release.
Loading