Add Composition.expand_op_modes to resolve OP_Mode from presets - #13
Draft
lefi7z wants to merge 3 commits into
Draft
Add Composition.expand_op_modes to resolve OP_Mode from presets#13lefi7z wants to merge 3 commits into
lefi7z wants to merge 3 commits into
Conversation
Build a new Composition from translate_op_modes output so OP_Mode placeholders become concrete set-values. Accepts a presets XML path or the dict from parse_presets_file. Co-authored-by: lefi7z <lefi7z@users.noreply.github.com>
Import os and parse_presets_file at module level; always call translate_op_modes with check=False. Co-authored-by: lefi7z <lefi7z@users.noreply.github.com>
Member
Author
|
There are a lot more adresses of interest that would need to be considered here, e.g. the Flow-Controllers especially! See Maybe it's not worth the effort right now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Composition.expand_op_modes(presets)to produce a new composition whereOP_Modesteps are replaced by the concrete set-values from a presets file.translate_op_modeswithcheck=False(expansion does not require a full reaction-parameter set on every step).presetsmay be a path to the presets XML (parse_presets_file) or the parsed dict.max_runs,start_cycle, andspec_duration_msunchanged; leaves the original composition untouched.Usage