chore(lint): fix lint warnings and fail lint on warnings

eslint.config.js

@@ -13,8 +13,6 @@ module.exports = defineConfig([
     extends: [angular.configs.tsRecommended],
     processor: angular.processInlineTemplates,
     rules: {
-      // Ionic's base level; `recommended` makes it an error, which is meant for libraries.
-      '@typescript-eslint/explicit-module-boundary-types': 'warn',
       '@typescript-eslint/explicit-member-accessibility': 'off',
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-inferrable-types': ['error', { ignoreParameters: true }],

package.json

@@ -12,7 +12,7 @@
     "lint": "npm run eslint && npm run lint:sass && npm run prettier -- --check",
     "lint:sass": "stylelint \"src/**/*.scss\"",
     "lint:fix": "npm run eslint -- --fix && npm run prettier -- --write",
-    "eslint": "ng lint",
+    "eslint": "ng lint --max-warnings 0",
     "prettier": "prettier \"**/*.{ts,html}\""
   },
   "repository": {

src/app/app.component.ts

@@ -114,7 +114,7 @@ export class AppComponent implements OnInit {
     });
   }
 
-  async ngOnInit() {
+  async ngOnInit(): Promise<void> {
     this.initializeApp();
     await this.storage.create();
     this.checkLoginStatus();
@@ -141,7 +141,7 @@ export class AppComponent implements OnInit {
     });
   }
 
-  initializeApp() {
+  initializeApp(): void {
     this.platform.ready().then(() => {
       if (this.platform.is('hybrid')) {
         StatusBar.hide();
@@ -150,19 +150,19 @@ export class AppComponent implements OnInit {
     });
   }
 
-  checkLoginStatus() {
+  checkLoginStatus(): Promise<void> {
     return this.userService.isLoggedIn().then((loggedIn) => {
       return this.updateLoggedInStatus(loggedIn);
     });
   }
 
-  updateLoggedInStatus(loggedIn: boolean) {
+  updateLoggedInStatus(loggedIn: boolean): void {
     setTimeout(() => {
       this.loggedIn.set(loggedIn);
     }, 300);
   }
 
-  listenForLoginEvents() {
+  listenForLoginEvents(): void {
     window.addEventListener('user:login', () => {
       this.updateLoggedInStatus(true);
     });
@@ -176,19 +176,19 @@ export class AppComponent implements OnInit {
     });
   }
 
-  logout() {
+  logout(): void {
     this.userService.logout().then(() => {
       return this.router.navigateByUrl('/app/tabs/schedule');
     });
   }
 
-  openTutorial() {
+  openTutorial(): void {
     this.menu.enable(false);
     this.storage.set('ion_did_tutorial', false);
     this.router.navigateByUrl('/tutorial');
   }
 
-  toggleDarkMode() {
+  toggleDarkMode(): void {
     document.documentElement.classList.toggle('ion-palette-dark', this.dark);
   }
 }

src/app/pages/about-popover/about-popover.ts

@@ -29,12 +29,12 @@ export class PopoverPage {
   private router = inject(Router);
   private popoverCtrl = inject(PopoverController);
 
-  support() {
+  support(): void {
     this.router.navigate(['/support']);
     this.popoverCtrl.dismiss();
   }
 
-  close(url: string) {
+  close(url: string): void {
     window.open(url, '_blank');
     this.popoverCtrl.dismiss();
   }

src/app/pages/about/about.ts

@@ -64,7 +64,7 @@ export class AboutPage {
     addIcons({ ellipsisHorizontal, ellipsisVertical });
   }
 
-  async presentPopover(event: Event) {
+  async presentPopover(event: Event): Promise<void> {
     const popover = await this.popoverCtrl.create({
       component: PopoverPage,
       event,

src/app/pages/account/account.ts

@@ -30,18 +30,18 @@ export class AccountPage implements AfterViewInit {
 
   username = signal<string>('');
 
-  ngAfterViewInit() {
+  ngAfterViewInit(): void {
     this.getUsername();
   }
 
-  updatePicture() {
+  updatePicture(): void {
     console.log('Clicked to update picture');
   }
 
   // Present an alert with the current username populated
   // clicking OK will update the username and display it
   // clicking Cancel will close the alert and do nothing
-  async changeUsername() {
+  async changeUsername(): Promise<void> {
     const alert = await this.alertCtrl.create({
       header: 'Change Username',
       buttons: [
@@ -67,22 +67,22 @@ export class AccountPage implements AfterViewInit {
     await alert.present();
   }
 
-  getUsername() {
+  getUsername(): void {
     this.user.getUsername().then((username) => {
       this.username.set(username ?? '');
     });
   }
 
-  changePassword() {
+  changePassword(): void {
     console.log('Clicked to change password');
   }
 
-  logout() {
+  logout(): void {
     this.user.logout();
     this.router.navigateByUrl('/login');
   }
 
-  support() {
+  support(): void {
     this.router.navigateByUrl('/support');
   }
 }

src/app/pages/login/login.ts

@@ -43,7 +43,7 @@ export class LoginPage {
   login: UserOptions = { username: '', password: '' };
   submitted = false;
 
-  onLogin(form: NgForm) {
+  onLogin(form: NgForm): void {
     this.submitted = true;
 
     if (form.valid) {
@@ -52,7 +52,7 @@ export class LoginPage {
     }
   }
 
-  onSignup() {
+  onSignup(): void {
     this.router.navigateByUrl('/signup');
   }
 }

src/app/pages/map/map.ts

@@ -37,7 +37,7 @@ export class MapPage implements AfterViewInit {
 
   @ViewChild('mapCanvas', { static: true }) mapElement!: ElementRef;
 
-  ngAfterViewInit() {
+  ngAfterViewInit(): void {
     this.locationService
       .loadLocations()
       .pipe(takeUntilDestroyed(this.destroyRef))

src/app/pages/schedule-filter/schedule-filter.ts

@@ -82,7 +82,7 @@ export class ScheduleFilterPage {
     });
   }
 
-  ionViewWillEnter() {
+  ionViewWillEnter(): void {
     this.ios.set(this.config.get('mode') === 'ios');
 
     // passed in array of track names that should be excluded (unchecked)
@@ -100,20 +100,20 @@ export class ScheduleFilterPage {
     });
   }
 
-  selectAll(check: boolean) {
+  selectAll(check: boolean): void {
     // set all to checked or unchecked
     this.tracks.update((tracks) => tracks.map((track) => ({ ...track, isChecked: check })));
   }
 
-  applyFilters() {
+  applyFilters(): void {
     // Pass back a new array of track names to exclude
     const excludedTrackNames = this.tracks()
       .filter((c) => !c.isChecked)
       .map((c) => c.name);
     this.dismiss(excludedTrackNames);
   }
 
-  dismiss(data?: string[]) {
+  dismiss(data?: string[]): void {
     // using the injected ModalController this page
     // can "dismiss" itself and pass back data
     this.modalCtrl.dismiss(data);

src/app/pages/schedule/schedule.ts

@@ -110,12 +110,12 @@ export class SchedulePage implements OnInit {
     });
   }
 
-  ngOnInit() {
+  ngOnInit(): void {
     this.updateSchedule();
     this.ios = this.config.get('mode') === 'ios';
   }
 
-  updateSchedule() {
+  updateSchedule(): void {
     // Close any open sliding items when the schedule updates
     if (this.scheduleList) {
       this.scheduleList.closeSlidingItems();
@@ -134,7 +134,7 @@ export class SchedulePage implements OnInit {
       });
   }
 
-  async presentFilter() {
+  async presentFilter(): Promise<void> {
     const modal = await this.modalCtrl.create({
       component: ScheduleFilterPage,
       presentingElement: this.routerOutlet.nativeEl,
@@ -149,7 +149,7 @@ export class SchedulePage implements OnInit {
     }
   }
 
-  async addFavorite(slidingItem: IonItemSliding, sessionData: Session) {
+  async addFavorite(slidingItem: IonItemSliding, sessionData: Session): Promise<void> {
     if (this.user.hasFavorite(sessionData.name)) {
       // Prompt to remove favorite
       this.removeFavorite(slidingItem, sessionData, 'Favorite already added');
@@ -177,7 +177,7 @@ export class SchedulePage implements OnInit {
     }
   }
 
-  async removeFavorite(slidingItem: IonItemSliding, sessionData: Session, title: string) {
+  async removeFavorite(slidingItem: IonItemSliding, sessionData: Session, title: string): Promise<void> {
     const alert = await this.alertCtrl.create({
       header: title,
       message: 'Would you like to remove this session from your favorites?',
@@ -207,7 +207,7 @@ export class SchedulePage implements OnInit {
     await alert.present();
   }
 
-  async openSocial(network: string, fab: IonFab) {
+  async openSocial(network: string, fab: IonFab): Promise<void> {
     const loading = await this.loadingCtrl.create({
       message: `Posting to ${network}`,
       duration: Math.random() * 1000 + 500,

src/app/pages/session-detail/session-detail.ts

@@ -51,7 +51,7 @@ export class SessionDetailPage {
     addIcons({ shareOutline, starOutline, star, cloudDownload, share });
   }
 
-  ionViewWillEnter() {
+  ionViewWillEnter(): void {
     this.confService.load().subscribe((data) => {
       if (data && data.schedule && data.schedule[0] && data.schedule[0].groups) {
         const sessionId = this.route.snapshot.paramMap.get('sessionId');
@@ -72,15 +72,15 @@ export class SessionDetailPage {
     });
   }
 
-  ionViewDidEnter() {
+  ionViewDidEnter(): void {
     this.defaultHref.set('/app/tabs/schedule');
   }
 
-  sessionClick(item: string) {
+  sessionClick(item: string): void {
     console.log('Clicked', item);
   }
 
-  toggleFavorite() {
+  toggleFavorite(): void {
     const sessionName = this.session()?.name;
     if (!sessionName) {
       return;
@@ -94,7 +94,7 @@ export class SessionDetailPage {
     }
   }
 
-  shareSession() {
+  shareSession(): void {
     console.log('Clicked share session');
   }
 }

src/app/pages/signup/signup.ts

@@ -43,7 +43,7 @@ export class SignupPage {
   signup: UserOptions = { username: '', password: '' };
   submitted = false;
 
-  onSignup(form: NgForm) {
+  onSignup(form: NgForm): void {
     this.submitted = true;
 
     if (form.valid) {

src/app/pages/speaker-detail/speaker-detail.ts

@@ -64,7 +64,7 @@ export class SpeakerDetailPage {
     });
   }
 
-  ionViewWillEnter() {
+  ionViewWillEnter(): void {
     this.confService.load().subscribe((data) => {
       const speakerId = this.route.snapshot.paramMap.get('speakerId');
       if (data && data.speakers) {
@@ -78,11 +78,11 @@ export class SpeakerDetailPage {
     });
   }
 
-  openExternalUrl(url: string) {
+  openExternalUrl(url: string): void {
     window.open(url, '_blank');
   }
 
-  async openSpeakerShare(speaker: any) {
+  async openSpeakerShare(speaker: any): Promise<void> {
     const actionSheet = await this.actionSheetCtrl.create({
       header: 'Share ' + speaker.name,
       buttons: [
@@ -108,7 +108,7 @@ export class SpeakerDetailPage {
     await actionSheet.present();
   }
 
-  async openContact(speaker: Speaker) {
+  async openContact(speaker: Speaker): Promise<void> {
     const mode = 'ios'; // this.config.get('mode');
 
     const actionSheet = await this.actionSheetCtrl.create({

src/app/pages/speaker-list/speaker-list.ts

@@ -51,7 +51,7 @@ export class SpeakerListPage {
 
   speakers = signal<Speaker[]>([]);
 
-  ionViewDidEnter() {
+  ionViewDidEnter(): void {
     this.confData.getSpeakers().subscribe((speakers) => {
       this.speakers.set(speakers);
     });

src/app/pages/support/support.ts

@@ -42,15 +42,15 @@ export class SupportPage {
   submitted = false;
   supportMessage: string;
 
-  async ionViewDidEnter() {
+  async ionViewDidEnter(): Promise<void> {
     const toast = await this.toastCtrl.create({
       message: 'This does not actually send a support request.',
       duration: 3000,
     });
     await toast.present();
   }
 
-  async submit(form: NgForm) {
+  async submit(form: NgForm): Promise<void> {
     this.submitted = true;
 
     if (form.valid) {

src/app/pages/tutorial/tutorial.ts

@@ -25,13 +25,13 @@ export class TutorialPage {
     });
   }
 
-  startApp() {
+  startApp(): void {
     this.router
       .navigateByUrl('/app/tabs/schedule', { replaceUrl: true })
       .then(() => this.storage.set('ion_did_tutorial', true));
   }
 
-  ionViewWillEnter() {
+  ionViewWillEnter(): void {
     this.storage.get('ion_did_tutorial').then((res) => {
       if (res === true) {
         this.router.navigateByUrl('/app/tabs/schedule', { replaceUrl: true });
@@ -41,7 +41,7 @@ export class TutorialPage {
     this.menu.enable(false);
   }
 
-  ionViewWillLeave() {
+  ionViewWillLeave(): void {
     // enable the root left menu when leaving the tutorial page
     this.menu.enable(true);
   }