Add system theme preference support using respectPrefersColorScheme#470
Open
KhanjarSingh wants to merge 1 commit intoionic-team:mainfrom
Open
Add system theme preference support using respectPrefersColorScheme#470KhanjarSingh wants to merge 1 commit intoionic-team:mainfrom
KhanjarSingh wants to merge 1 commit intoionic-team:mainfrom
Conversation
This PR enables **automatic theme detection** based on the user's operating system settings. By adding: ```js respectPrefersColorScheme: true
|
@KhanjarSingh is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@eric-horodyski i have created a pr. I would like you to go through this and merge if you like it.. |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables automatic theme detection based on the user's operating system settings.
By adding:
respectPrefersColorScheme: truehe site now respects the user's system-level dark or light mode on their first visit, aligning with the “System Default” theme behavior.
✅ What’s Already Working
Theme toggle button (enabled by default)
Light/Dark mode switching
localStorage persistence
Dark mode logos configured
🔧 What’s New
Added respectPrefersColorScheme: true to automatically set theme based on OS preference
🧪 Testing
Open the site in an incognito/private window.
Change your system theme to dark/light mode.
Reload the page — it should match your OS theme automatically.