fix(ios): set IPHONEOS_DEPLOYMENT_TARGET to 15.0 across all packages#9108
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9108 +/- ##
============================================
- Coverage 65.14% 64.96% -0.17%
- Complexity 1833 1838 +5
============================================
Files 503 409 -94
Lines 39184 26401 -12783
Branches 5805 4861 -944
============================================
- Hits 25521 17150 -8371
+ Misses 12192 8172 -4020
+ Partials 1471 1079 -392
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mikehardy
left a comment
There was a problem hiding this comment.
this is a good change as a start - can you add a cleanup chore commit that scans the entire ios codebase and cleans up any stale API availability checks that were looking for iOS 15 or below?
If there is a similar requirement that we're past for tvos/visionos/ipados/maccatalyst etc - that is, a deployment target that's stale and could be updated so the compiler knows more APIs are available - allowing us to clean out availability gates for those platforms, it would be good to get everything at once while we're here
iOS deployment target is now 15.0, so UNNotificationPresentationOptionBanner and UNNotificationPresentationOptionList are always available. Removes dead iOS 13 fallback branches and the associated TODO.
|
Addressed in 8a96a5d — scanned all Removed (2 guards):
Kept (8 guards):
Other platforms:
|
mikehardy
left a comment
There was a problem hiding this comment.
did a final pass - a little sad we can't remove any more of those conditionals - removing conditionality is a nice background task to pursue in general as it maintains simplicity but my audit of platform requirements and support matches up with current changes
during that audit I noticed that our platforms doc was stale for iOS minimum as well though, so I put in a final commit that bumps iOS to 15 from 13 and fixed up the Android minimum and adds the ai and phone-number-verification modules to platform support table as well
Ci should go green on lint and markdown which would verify my change then I think this is good to go
Summary
Updates
IPHONEOS_DEPLOYMENT_TARGETfrom10.0to15.0in all 16 package pbxproj files and the_TEMPLATE_pbxprojAligns with the
iosTarget: "15.0"already declared inpackages/app/package.jsonsdkVersionsPrevents new packages generated from the template from reintroducing the stale
10.0valueFixes this
@availableannotation shouldn't be necessary unless the pbxproj IPHONEOS_DEPLOYMENT_TARGET is wrong #8882Test plan
IPHONEOS_DEPLOYMENT_TARGET = 10.0values remain across all pbxproj filesgit diff --checkclean — no whitespace issues