Guard REST results against malformed responses - #422
Merged
isc-klu merged 1 commit intoSep 10, 2026
Merged
Conversation
Fixes intersystems#421. Three sites in definition.ts dereferenced respdata.data.result.content after only checking respdata !== undefined; 4xx bodies passed through by makeRESTRequest have no result, so this threw. Guard them the same way the rest of the file already does.
isc-klu
changed the title
isc-klu
marked this pull request as ready for review
September 10, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421
Root cause: Three REST call sites in
definition.ts(/action/getmacrolocationand two/action/index) dereferencerespdata.data.result.contentafter only checkingrespdata !== undefined.Solution: Guard all three with
?./Array.isArray(...), matching the pattern every other REST site in the file already uses.