Skip to content

Fix enforcer error after aws update - #1746

Merged
natechadwick-intsof merged 5 commits into
developmentfrom
docs/adopt-universal-code
Aug 3, 2026
Merged

Fix enforcer error after aws update#1746
natechadwick-intsof merged 5 commits into
developmentfrom
docs/adopt-universal-code

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Fix enforcer error

Pin Universal Code v1.0.0 in root and module agent instruction files
(AGENTS.md, CLAUDE.md, GEMINI.md) and document the adoption in README
with a link to the full canonical UC-v1.0.0.md.

> Co-Authored by Grok Build using Grok 4.5 with agent Grok.
Mirror UC-v1.0.0.md and UC-EMBED-v1.0.0.md under docs/policies/ so agent
and README pins do not depend on a live third-party URL. Pins now read the
vendored embed path; README links the vendored full form with upstream as
source. Upstream commit b7f9d517038af34d1fbe8a80ee8c4d4bb702e5c1.

Addresses review feedback on PR #1742.

> Co-Authored by Grok Build using Grok 4.5 with agent Grok.
Comment thread pom.xml
@kilo-code-bot

kilo-code-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge (low-risk nit)

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
pom.xml 136 Comment cites ${aws.sdk.v2.version} as if Maven interpolates XML comments (it does not). Future readers cannot verify the version claim without grepping for the property.
Files Reviewed (18 files)
  • pom.xml — 1 issue (HC5 management for enforcer; shape and dependencyManagement placement look correct; relative paths in vendored doc references are correct for each location: ../docs/... from root-level modules, ../../docs/... from modules/*/, and ../docs/... from WebUI/)
  • docs/policies/UC-EMBED-v1.0.0.md — new file, vendored from upstream commit b7f9d517…; HTML comment correctly pins the source commit and tells future editors to re-vendor rather than hand-edit the body
  • docs/policies/UC-v1.0.0.md — new file, same vendoring pattern; **Canonical source** line intentionally points at blob/main/… (latest) while the body is pinned to v1.0.0
  • AGENTS.md — vendored-policy line updated; new path resolves correctly from repo root
  • CLAUDE.md, GEMINI.md — same one-line update, both use the short embed variant
  • README.md — links the longer UC-v1.0.0.md (human-readable) plus the upstream repo; correct
  • WebUI/AGENTS.md, rest/AGENTS.md, system/AGENTS.md — all use ../docs/policies/... (root-level modules); paths resolve correctly
  • modules/CMLight-Main-cactus-tests/AGENTS.md, modules/extensions-main/AGENTS.md, modules/extensions-workflow/AGENTS.md, modules/perc-distribution-tree/AGENTS.md, modules/perc-i18n/AGENTS.md, modules/perc-jetty/AGENTS.md, modules/perc-qa-automation/AGENTS.md, projects/sitemanage/AGENTS.md — all use ../../docs/policies/...; paths resolve correctly

Substantive assessment

  • The pom.xml change is the real fix: adding <dependencyManagement> entries for httpclient5, httpcore5, and httpcore5-h2 is the right shape to converge the transitive httpcomponents.client5 / core5 versions pulled in by AntiSamy 1.7.8 (5.4.4/5.3.4) and the AWS SDK v2 apache5-client (5.6.2/5.4.3) at the upper bound. Placed in the existing <properties> and <dependencyManagement> blocks per root AGENTS.md (parent-POM-managed versions, no per-module duplication).
  • Vendoring the Universal Code locally matches the root AGENTS.md policy line and removes the external-URL dependency in 17 doc files. The HTML comment header on each vendored file is a good practice: it pins the source commit, distinguishes vendored content from project content, and tells future contributors to re-vendor rather than hand-edit.
  • No code logic changed, no tests required (build-config + doc-only change).
  • No secrets, no cross-platform path regressions, no Spring Boot imports introduced.

Style observation (not a flagged issue): across the 17 doc files the separator between the policy intro and the link changed from em-dash () to hyphen (-). This appears to be an intentional consistency pass; leaving the flag off since it is subjective and harmless.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 81.6K · Output: 8.2K · Cached: 484.6K

Review guidance: REVIEW.md from base branch development

Signed-off-by: Nate Chadwick <263952448+natechadwick-intsof@users.noreply.github.com>
@natechadwick-intsof
natechadwick-intsof merged commit 0c41584 into development Aug 3, 2026
4 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the docs/adopt-universal-code branch August 3, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant