feat: remove legacy login check + i18n test closure + agent completeness rules - #1738
Merged
Merged
Conversation
Re-vendor language client 0.4 with postUrl. Add POST /rest/i18n/corrections (resource + DTO in rest; GCM submit in sitemanage) with role gate, server.properties config, and ENC-ready PAT. WebUI posts CSRF-backed corrections to the BFF. Start scripts expose <installdir>/bin for mkd_gcm_ffi (LD_LIBRARY_PATH / PATH / jna). Requires local .m2 install of dev.monkeyking:mkd-gcm-sdk until published. > Co-Authored by Grok Build using Grok 4.5 with agent main.
Add Spring test stub for I18nCorrectionsAdaptor so MainTest context loads, and stub PSServer.ms_serverProps with PSProperties (declared field type). > Co-Authored by Grok Build using Grok 4.5 with agent Grok.
Codify multi-layer companion delivery as a monorepo hard gate, and require explicit human review of all agent rule/instruction changes before commit. Rule wording is intended for PR review in the GitHub UI. > Co-Authored by Grok Build using Grok 4.5 with agent Grok.
> Co-Authored by Grok Build using Grok 4.5 with agent Grok.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
NotesIncremental diff Resolved (commit
Re-verified on changed lines (no regressions):
New issues: None. Files Reviewed (2 changed files)
Previous Review Summaries (2 snapshots, latest commit 6ac0099)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6ac0099)Status: 1 Issue Found (incremental) | Recommendation: Address before merge Overview
NotesWhat was reviewed (incremental diff 051a477..6ac0099, ≈13k diff lines, ~16 files):
Previous review (commit
New issue (1)WARNING
Files Reviewed (16 changed files)
Fix these issues in Kilo Cloud Previous review (commit 051a477)Status: 9 Issues Found | Recommendation: Address before merge Overview
NotesWhat was reviewed (≈50 files, ~12k diff lines):
Strengths worth acknowledging:
Top issues (full inline comments on the PR):
No critical / security-blocking issues found. Fix these issues in Kilo Cloud Reply with Files Reviewed (53 files)Click to expandJava backend (new REST BFF + impl + tests)
System / login legacy removal
WebUI (TS/TSX + JSP + Vitest)
Playwright
AGENTS / skills / agent docs
Jetty launchers
Vendored library + lockfile (sanity checked)
Reviewed by minimax-m3 · Input: 42.7K · Output: 1.9K · Cached: 312.6K Review guidance: REVIEW.md from base branch |
Resolve i18n_translate.json via resolve_i18n_cache_conflicts.py (union both sides). > Co-Authored by Grok Build using Grok 4.5 with agent Grok.
- Log throwable as last arg in I18nCorrectionsResource - AtomicBoolean for once-only empty-roles warn - MkdGcmBackendException without SDK message echo - Warn on invalid gcm port; decrypt failure vs not-configured - Remove unused encryptTokenAtStartupIfPlain - Deterministic role-supplier seam in adaptor tests - Playwright header assert via dashboard.jsp - Pin commons-email version from parent BOM > Co-Authored by Grok Build using Grok 4.5 with agent Grok.
> Co-Authored by Grok Build using Grok 4.5 with agent Grok.
Collaborator
Author
Review resolutionMerged Addressed all 9 Kilo threads in
All review threads replied + resolved. Local: rest i18n/MainTest green; |
natechadwick
previously approved these changes
Aug 2, 2026
Avoid IllegalStateException / encryptor stack leakage when ENC(...) is misconfigured; log summary only checks property presence. > Co-Authored by Grok Build using Grok 4.5 with agent Grok.
natechadwick
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestI18nCorrectionsAdaptorsoMainTestloads;I18nCorrectionsAdaptorImplTestusesPSPropertiesforPSServer.ms_serverProps.AGENTS.md: Human review of agent rules (you review all rule commits) + Change-class completeness (full companion closure, not primary artifact + one unit test).rest/sitemanageAGENTS.Rule review focus (GitHub Files tab)
AGENTS.mdrest/AGENTS.mdprojects/sitemanage/AGENTS.mdmodules/ai-shared-develop/src/main/resources/agents/erlang-code-review.mdmodules/ai-shared-develop/src/main/resources/skills/erlang-review/patterns.mdmodules/ai-shared-develop/src/main/resources/skills/java-unit-testing/SKILL.mdCommits of interest
fix(rest/sitemanage): complete i18n corrections test closure— product/testdocs(agents): change-class completeness + human rule review gate— rule reviewstyle: Spotless format…— formatting onlyTest plan
cd rest && ../mvnw.cmd test— 167 tests green (after Spring stub)cd projects/sitemanage && ../../mvnw.cmd test -Dtest=I18nCorrectionsAdaptorImplTest— 5 tests green