feat: add fr-ca variant - #1737
Merged
Merged
Conversation
natechadwick
commented
Aug 1, 2026
natechadwick
commented
Collaborator
- add fr-ca locale
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summaries (2 snapshots, latest commit abb44f0)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit abb44f0)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Incremental review note (commit Fix these issues in Kilo Cloud Previous review (commit 88ff2f8)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Reviewed by minimax-m3 · Input: 72K · Output: 1.8K · Cached: 280.6K Review guidance: REVIEW.md from base branch |
# Conflicts: # modules/perc-i18n/scripts/cache/i18n_translate.json # modules/perc-i18n/src/main/resources/i18n/CmsUi.tmx # modules/perc-i18n/src/main/resources/i18n/DeveloperUi.tmx # modules/perc-i18n/src/main/resources/i18n/SystemResources.tmx
PR #1737 review: en-us and base fr both use editWidgetCommit as a stable internal identifier (layout controller alert). The fr-ca modifierWidgetCommit regional override could break lookup/dispatch for fr-ca only. Omitting the override restores fallback to fr per perc-i18n base vs regional storage rules. Co-Authored by Grok Build using grok-4.5 with agent Grok.
natechadwick-intsof
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.