Feat/webui mkd language alpha integration - #1736
Merged
Merged
Conversation
…ion UX Ship a vendored build of the third-party @mkd/language client so developer and customer builds work without the mkd workspace or npm publish. Add a thin adapter (opt-in via ?mkdLang=1 / localStorage), data-i18n-key helpers, and pilot wiring on login, logout, and SPA shell chrome. Alpha submissions use the library no-op client. > Co-Authored by Grok Build using Grok 4.5 with agent main.
Re-vendor @mkd/language 0.2.0 and wrap product message() with createTrackedMessage so correction popovers resolve TMX keys without mass template annotation. Adapter passes getTrackedMessageId on init; explicit i18nKeyAttr remains optional for collisions only. > Co-Authored by Grok Build using Grok 4.5 with agent main.
…8005 Offline DTS checks assert free connector ports but server.xml used hardcoded Tomcat shutdown port 8005. A running local DTS made checkTomcatServerRunning return true and failed free-port assertions intermittently. Use distinct free ports for connector and shutdown; add coverage for shutdown-only bind. > Co-Authored by Grok Build using Grok 4.5 with agent main.
Bind frontend-maven-plugin npm-test (npm run test) to the test phase so clean install and CI catch broken modern TS/React unit tests. Honors -DskipTests like Surefire. Document in WebUI/AGENTS.md. > Co-Authored by Grok Build using Grok 4.5 with agent main.
Burn down failures exposed by binding npm test to the Maven test phase: align i18n assertions with message() fallback labels, fix ExplorerTree self-path recursion, dual-tree spa.jsp developer parity, a11y/axe jsdom setup, legacy percUtils/form/slider tests, and stale import paths. Verified: 177 files / 1118 tests passed (exit 0). > Co-Authored by Grok Build using Grok 4.5 with agent main.
With tracked message() covering catalog keys, focus Phase C on skipping user content (explorer names, detail rows, search hit titles, home list labels, usernames, iframe gadgets, login credential fields). Phase D: popover z-index 20000, product theme CSS variables, respectIgnore on. > Co-Authored by Grok Build using Grok 4.5 with agent main.
InteractiveInstallWizard now applies last-install.properties defaults. Tests that call runPhase1 with a null CLI path were reading the real cms.install.directory (e.g. C:\Installs\…) and failing path/usage assertions. Route all wizard tests through an injectable fake user.home (same for DTS wizard) and cover applyDefaults from saved settings. > Co-Authored by Grok Build using Grok 4.5 with agent main.
…mkd-language pilot.
…avoind extermely slow spotless scans
…avoind extermely slow spotless scans
Resolve conflicts with development (AWS SDK v2 from #1735, DTS Jackson classpath fixes from this branch, Hebrew locale docs, auth helper style). > Co-Authored by Grok Build using grok-4.5 with agent Grok.
Pre-push hook reformatted the merge result from development. > Co-Authored by Grok Build using grok-4.5 with agent Grok.
natechadwick
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Spotless/Prettier had moved // codeql[js/xss-through-dom] onto the
.attr('src') key line; CodeQL alerts on the safeThumbnailSrc(...) value
line. Put end-of-line suppressions on both imageSlider package copies.
> Co-Authored by Grok Build using grok-4.5 with agent Grok.
natechadwick-intsof
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.