chore: remove mvn-env wrappers; document Maven wrapper only by natechadwick-intsof · Pull Request #1590 · intersoftdatalabs-in/percussioncms

natechadwick-intsof · 2026-07-29T02:09:50Z

Summary

Remove repo-root mvn-env.sh / mvn-env.bat (and the SC-004 sentinel that guarded them). Agents were routinely confused by dual wrapper paths and relative-path depth math.
Point all markdown, agent guidance, and script/docker/skill callers at the standard Maven wrapper: ./mvnw / mvnw.cmd.
Clarify that JDK 21 must be set via JAVA_HOME (the old wrappers rewrote JAVA_HOME from JAVA_HOME_21; mvnw does not).

What changed

Area	Change
Deleted	`mvn-env.sh`, `mvn-env.bat`, `scripts/test_mvn_env_untouched.py`
Docs / AGENTS	~230 markdown files rewritten to `mvnw` / `mvnw.cmd`
Call sites	Python install/hot-deploy/docker scripts, skill install helpers, CodeQL path filters, pom comments
Build guidance	Root `AGENTS.md`, `README.md`, `CONTRIBUTING.md`, `WINDOWS-BUILD-GUIDE.md`

How to build after this PR

# JAVA_HOME must be JDK 21
./mvnw clean install

# Windows
mvnw.cmd clean install

# Per-module (from module dir)
cd rest && ../mvnw clean install

Test plan

Confirm mvn-env.sh / mvn-env.bat are gone from the branch tip
./mvnw -v works with JAVA_HOME → JDK 21
Spot-check agent docs: root AGENTS.md Pre-PR section uses mvnw only
Optional: python3 -m pytest docker/scripts/test_perc_devctl.py -q (stub now creates mvnw)
No Maven product modules changed — no module clean install required (docs + tooling only)

Notes

Docs-only / tooling change for product code; PR body records that no Java module clean install was needed.
Spec 994 historical SC-004 / test_mvn_env_untouched notes updated so agents do not look for the deleted sentinel.

Co-Authored by Grok Build using grok-4.5 with agent Grok.

Delete repo-root mvn-env.sh / mvn-env.bat (and the SC-004 sentinel that guarded them). Agents and docs were routinely confused by the dual wrapper paths; builds should use the standard Maven wrapper with JDK 21. - Replace all markdown references with ./mvnw / mvnw.cmd - Point scripts/docker/skills callers at mvnw (Windows: mvnw.cmd) - Clarify JAVA_HOME must be JDK 21 (wrapper no longer rewrites JAVA_HOME) - Drop scripts/test_mvn_env_untouched.py; update CodeQL path filters > Co-Authored by Grok Build using grok-4.5 with agent Grok.

kilo-code-bot · 2026-07-29T02:15:30Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (9 files)

system/AGENTS.md - clean
system/README.md - clean
system/business/README.md - deleted
system/business/refactored-java11-packages.txt - deleted
system/services/README.md - resolved (previous suggestion fixed)
system/services/refactored-java11-packages.txt - deleted
system/servlet/README.md - deleted
system/webservices/README.md - clean
system/webservices/refactored-soap-packages.txt - deleted

Previous Review Summaries (5 snapshots, latest commit 0be3bd0)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `0be3bd0`)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`system/services/README.md`	5	Missing `mvnw.cmd` reference in toolchain line — only shows `./mvnw`, inconsistent with PR goal and sibling READMEs

Files Reviewed (9 files)

system/AGENTS.md - clean
system/README.md - clean
system/business/README.md - deleted
system/business/refactored-java11-packages.txt - deleted
system/services/README.md - 1 suggestion
system/services/refactored-java11-packages.txt - deleted
system/servlet/README.md - deleted
system/webservices/README.md - clean
system/webservices/refactored-soap-packages.txt - deleted

Fix these issues in Kilo Cloud

Previous review (commit `6a19674`)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	3
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`docker/scripts/perc-devctl.py`	465	Cross-platform path bug — `mvnw` without `.cmd` on Windows: `it-verify` invokes `repo_root / "mvnw"` directly, which fails on Windows where the wrapper is `mvnw.cmd`
`scripts/release-audit/port.py`	146	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `verify_tests` invokes `./mvnw` directly, which fails on Windows
`scripts/release-audit/port.py`	164	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `spotless_check` invokes `./mvnw` directly, which fails on Windows

WARNING

File	Line	Issue
`scripts/verify-distribution-archive.py`	22	Misleading comment: `mvnw` does not have cross-filesystem `mv` issues. The original comment accurately described why the bash script avoided `mvn-env.sh`; `mvnw` is the Maven wrapper, not a bash script

Files Reviewed (233 files)

docker/scripts/perc-devctl.py - 1 critical
scripts/release-audit/port.py - 2 critical
scripts/verify-distribution-archive.py - 1 warning
230 additional files - clean

Review ID: 035e49d6-6caa-4043-a768-8d6e2680fec7
Fix these issues in Kilo Cloud

Previous review (commit `5014fc3`)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	3
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`docker/scripts/perc-devctl.py`	465	Cross-platform path bug — `mvnw` without `.cmd` on Windows: `it-verify` invokes `repo_root / "mvnw"` directly, which fails on Windows where the wrapper is `mvnw.cmd`
`scripts/release-audit/port.py`	146	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `verify_tests` invokes `./mvnw` directly, which fails on Windows
`scripts/release-audit/port.py`	164	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `spotless_check` invokes `./mvnw` directly, which fails on Windows

WARNING

File	Line	Issue
`scripts/verify-distribution-archive.py`	22	Misleading comment: `mvnw` does not have cross-filesystem `mv` issues. The original comment accurately described why the bash script avoided `mvn-env.sh`; `mvnw` is the Maven wrapper, not a bash script

Files Reviewed (233 files)

docker/scripts/perc-devctl.py - 1 critical
scripts/release-audit/port.py - 2 critical
scripts/verify-distribution-archive.py - 1 warning
230 additional files - clean

Review ID: 035e49d6-6caa-4043-a768-8d6e2680fec7
Fix these issues in Kilo Cloud

Previous review (commit `83d2e1f`)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	3
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`docker/scripts/perc-devctl.py`	465	Cross-platform path bug — `mvnw` without `.cmd` on Windows: `it-verify` invokes `repo_root / "mvnw"` directly, which fails on Windows where the wrapper is `mvnw.cmd`
`scripts/release-audit/port.py`	146	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `verify_tests` invokes `./mvnw` directly, which fails on Windows
`scripts/release-audit/port.py`	164	Cross-platform path bug — `./mvnw` without `.cmd` on Windows: `spotless_check` invokes `./mvnw` directly, which fails on Windows

WARNING

File	Line	Issue
`scripts/verify-distribution-archive.py`	22	Misleading comment: `mvnw` does not have cross-filesystem `mv` issues. The original comment accurately described why the bash script avoided `mvn-env.sh`; `mvnw` is the Maven wrapper, not a bash script

Files Reviewed (233 files)

docker/scripts/perc-devctl.py - 1 critical
scripts/release-audit/port.py - 2 critical
scripts/verify-distribution-archive.py - 1 warning
230 additional files - clean

Review ID: 035e49d6-6caa-4043-a768-8d6e2680fec7
Fix these issues in Kilo Cloud

Previous review

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
`modules/perc-qa-automation/pom.xml`	74	Comment typo: "mvn-Maven wrapper" should be "Maven wrapper"

Files Reviewed (233 files)

modules/perc-qa-automation/pom.xml - 1 warning (232 files clean)

Review ID: ebd26ad0-2e2c-43d6-9557-ccbd6ee6659e
Fix these issues in Kilo Cloud

_{Reviewed by ling-3.0-flash:free · Input: 98.2K · Output: 8.1K · Cached: 280.5K}

_{Review guidance: REVIEW.md from base branch development}

Agents skip Spotless or panic when apply rewrites dozens of unrelated files. Root AGENTS.md now requires spotless:apply/check before every final PR commit (Java, docs, JS, TS), and mandates a separate "Spotless Cleanup" PR for formatting outside the task scope. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

natechadwick-intsof · 2026-07-29T02:40:32Z

Follow-up commit 8bb5442719: added Pre-PR Spotless formatting (HARD GATE) to root AGENTS.md.

spotless:apply + spotless:check before every final PR commit (Java and docs/JS/TS).
If Spotless rewrites files outside the agent’s task scope → keep only in-scope files on the feature PR; open a second chore: Spotless cleanup PR for the rest.
Explicit “do not freak out / do not stuff 100 unrelated files into the feature PR” hard bans.

Addresses kilo-code-bot review on PR #1590. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

Addresses kilo-code-bot CRITICAL/WARNING feedback on PR #1590: - docker/scripts/perc-devctl.py it-verify: pick mvnw vs mvnw.cmd by OS - scripts/release-audit/port.py verify_tests + spotless_check: same - scripts/verify-distribution-archive.py: restore accurate comment (bash avoided old mvn-env.sh, not the Maven wrapper) > Co-Authored by Grok Build using grok-4.5 with agent Grok.

…urrent targets Root and system agent docs still told agents to "use Java 17" or "Java 11+". development is release=21. Clarify: - development = JDK 21 only for new work - development-8.1.x = JDK 8 maintenance (unchanged) - Java 11/17 modernization checklists and CP-JAVA11 markers are historical - ai-shared-develop coding standards + Java 21 language instructions updated > Co-Authored by Grok Build using grok-4.5 with agent Grok.

building/overview/modernization/legacy/index/services still instructed "Modernize to Java 17". Align with release=21 baseline. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

system/README.md remains relevant as the module map + build/agent guide, but the appended package modernization diary is gone. - Delete system/business/README.md (100% package log; no structure) - Delete servlet README + refactored-*.txt tracking lists - Replace services/ and webservices/ READMEs with short current guides - Point system/AGENTS.md away from deleted tracking files > Co-Authored by Grok Build using grok-4.5 with agent Grok.

natechadwick-intsof · 2026-07-29T03:24:02Z

Spotless honesty check (gate we just wrote — I had not run it before prior commits on this PR):

Ran ./mvnw spotless:check / spotless:apply after the fact.
None of this PR’s files were among the files Spotless rewrote on apply.
Five out-of-scope XML resources were reformatted → shipped as separate cleanup PR (not mixed into this PR).
Full-repo check can still fail on other baseline debt (e.g. Prettier on docs/index.html when Node is not available to the plugin).

Cleanup PR: linked after create.

natechadwick-intsof · 2026-07-29T03:24:08Z

Spotless cleanup PR for the 5 out-of-scope XMLs: #1591

Align system/services/README.md with sibling system READMEs and the cross-platform Maven wrapper docs standard (./mvnw / mvnw.cmd). Co-Authored by Grok Build using grok with agent pr-babysit.

Baseline Spotless rewrites outside PR #1590 (mvn-env / agent docs). Formatting-only; no product logic. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

kilo-code-bot Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread modules/perc-qa-automation/pom.xml Outdated

fix(docs): correct mvn-Maven wrapper typo in perc-qa-automation pom

83d2e1f

Addresses kilo-code-bot review on PR #1590. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

kilo-code-bot Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread docker/scripts/perc-devctl.py Outdated

Comment thread scripts/release-audit/port.py Outdated

Comment thread scripts/release-audit/port.py Outdated

Comment thread scripts/verify-distribution-archive.py Outdated

natechadwick-intsof added 4 commits July 28, 2026 23:06

docs(system): point site markdown agent guides at JDK 21

6a19674

building/overview/modernization/legacy/index/services still instructed "Modernize to Java 17". Align with release=21 baseline. > Co-Authored by Grok Build using grok-4.5 with agent Grok.

natechadwick-intsof mentioned this pull request Jul 29, 2026

chore: Spotless cleanup (XML comments) #1591

Merged

2 tasks

kilo-code-bot Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread system/services/README.md Outdated

docs(system): mention mvnw.cmd in services/README toolchain line

e310ff2

Align system/services/README.md with sibling system READMEs and the cross-platform Maven wrapper docs standard (./mvnw / mvnw.cmd). Co-Authored by Grok Build using grok with agent pr-babysit.

natechadwick merged commit 6813653 into development Jul 29, 2026
8 checks passed

natechadwick deleted the chore/remove-mvn-env-wrappers branch July 29, 2026 04:24

Uh oh!

Conversation

natechadwick-intsof commented Jul 29, 2026

Summary

What changed

How to build after this PR

Test plan

Notes

Uh oh!

Uh oh!

kilo-code-bot Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Previous review (commit 0be3bd0)

Overview

SUGGESTION

Previous review (commit 6a19674)

Overview

CRITICAL

WARNING

Previous review (commit 5014fc3)

Overview

CRITICAL

WARNING

Previous review (commit 83d2e1f)

Overview

CRITICAL

WARNING

Previous review

Overview

WARNING

Uh oh!

natechadwick-intsof commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

natechadwick-intsof commented Jul 29, 2026

Uh oh!

natechadwick-intsof commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot Bot commented Jul 29, 2026 •

edited

Loading

Previous review (commit `0be3bd0`)

Previous review (commit `6a19674`)

Previous review (commit `5014fc3`)

Previous review (commit `83d2e1f`)