fix(docker): tear down matrix-started external DBs after smoke (#1516) - #1543
Merged
natechadwick merged 1 commit intoJul 27, 2026
Merged
Conversation
Stop external compose DB containers that matrix-install-smoke started, while reusing and preserving pre-existing operator-owned DBs by default. Add --keep-db / --stop-db, document policy, and cover ownership logic with unit tests (no live Docker). Co-Authored by Grok Build (xAI) Grok 4.5 using grok-4.5 with agent Grok.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by step-3.7-flash · Input: 67.4K · Output: 11.3K · Cached: 436.1K Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matrix-install-smokefinishes (pass or fail), stop external compose DBs that this process started (compose stop; no volume wipe).--stop-db.--keep-db(leave DBs, destroy cells) and--stop-db(hard-stop all engaged external DBs);--keepstill leaves cells and DBs for Playwright Layer 2.docker/README.mdand harness help; unit tests cover ownership decision logic without live Docker.Closes #1516
Test plan
python -m pytest docker/scripts/test_matrix_install_smoke.py -v— 25 passedpython docker/scripts/matrix-install-smoke.py --helpshows--keep-db/--stop-db--product cms --db postgresqlthen confirmpercussion-postgresis stopped when matrix started it--stop-db, confirm container left running--keepleaves cell + DB;--keep-dbdestroys cell but leaves DBPre-PR verification
pom.xml/ Java sources changed).docs/ai-generated/code-reviews/1516-matrix-install-smoke-db-teardown-erlang.mddocker/scripts/test_matrix_install_smoke.py(25 passed)