Skip to content

fix(1500): DTS matrix smoke green for H2, PostgreSQL, MySQL, SQL Server - #1509

Merged
natechadwick-intsof merged 1 commit into
developmentfrom
1500-dts-matrix-smoke
Jul 26, 2026
Merged

fix(1500): DTS matrix smoke green for H2, PostgreSQL, MySQL, SQL Server#1509
natechadwick-intsof merged 1 commit into
developmentfrom
1500-dts-matrix-smoke

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Makes the DTS Layer-1 install matrix smoke green for the same DB set as CMS (#1507): H2, PostgreSQL, MySQL, SQL Server.

Root causes after EE11 / Tomcat 11 packaging (#1492):

  1. Stock Tomcat server.xml on 8080 while product/matrix expect ${http.port} = 9980 via perc-catalina.properties.
  2. catalina.properties missing common/lib on common.loader and missing PROPERTY_SOURCE=com.percussion.tomcat.PSTomcatPropertySource.
  3. PSSimpleRedirectorValve missing package declaration → class compiled to jar root; digester CNFE → FATAL "Cannot start server".

Fixes

  • Restore property-driven server.xml (connectors + redirector valve).
  • Wire Percussion catalina.properties (common/lib + PROPERTY_SOURCE).
  • Antrun force-overwrite Percussion conf after cargo stage (guards stale target/package).
  • Add package com.percussion.tomcat.valves; to PSSimpleRedirectorValve.
  • Packaging tests: ${http.port} / PROPERTY_SOURCE in shipping jar; nested jar valve path.

Matrix evidence

Cell Result
dts-h2 RESULT:OK HTTP 200 (~34s)
dts-postgresql RESULT:OK HTTP 200 (~40s)
dts-mysql RESULT:OK HTTP 200 (~56s)
dts-sqlserver RESULT:OK HTTP 200 (~66s)
python3 docker/scripts/matrix-install-smoke.py --product dts --db h2,postgresql,mysql,sqlserver

Pre-PR Maven (standalone)

cd deliverytiersuite/delivery-tier-suite/tomcat-common && ../../../mvn-env.sh clean install
# BUILD SUCCESS

cd deliverytiersuite/delivery-tier-suite/delivery-tier-distribution && ../../../mvn-env.sh clean install
# BUILD SUCCESS — Tests run: 69, Failures: 0

No new warnings attributable to this change (baseline javadoc noise unchanged).

Erlang

docs/ai-generated/code-reviews/1500-dts-matrix-smoke-erlang.mdapprove, May commit/push: yes.

Related

Test plan

  • Unit packaging tests green (Tomcat tree + common/lib + valve package path)
  • DTS H2 matrix smoke HTTP 200
  • DTS PostgreSQL matrix smoke HTTP 200
  • DTS MySQL matrix smoke HTTP 200
  • DTS SQL Server matrix smoke HTTP 200
  • CI green on PR

Co-Authored by Grok Build using grok-4.5 with agent Grok.

Restore property-driven Tomcat conf so DTS listens on ${http.port}=9980
(not stock 8080), wire common/lib + PSTomcatPropertySource, and fix
missing package on PSSimpleRedirectorValve so digester can load the
redirector valve. Package tests guard jar layout; matrix Layer-1 OK
for all four DB cells.

Co-Authored by Grok Build using grok-4.5 with agent Grok.
@natechadwick-intsof
natechadwick-intsof enabled auto-merge (squash) July 26, 2026 16:16
@natechadwick-intsof
natechadwick-intsof merged commit 94013eb into development Jul 26, 2026
4 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the 1500-dts-matrix-smoke branch July 26, 2026 16:22
@natechadwick-intsof natechadwick-intsof linked an issue Jul 26, 2026 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backlog: Add PostgreSQL as a supported CMS database backend

1 participant