[PB-5897] Fix participant count and zombies on reload#213
Open
TamaraFinogina wants to merge 8 commits intomainfrom
Open
[PB-5897] Fix participant count and zombies on reload#213TamaraFinogina wants to merge 8 commits intomainfrom
TamaraFinogina wants to merge 8 commits intomainfrom
Conversation
TamaraFinogina
changed the title
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
meet-web | 51dc483 | Commit Preview URL Branch Preview URL |
May 07 2026, 04:23 PM |
TamaraFinogina
changed the title
CandelR
reviewed
Apr 29, 2026
|
|
||
| fetch(`${MEET_API_URL}/call/${callId}/users/leave`, { | ||
| method: "POST", | ||
| keepalive: true, |
There was a problem hiding this comment.
waiting for what we discussed about handling this with a keepalive so that the browser doesn't close the request when the page is refreshed :)
Author
There was a problem hiding this comment.
Done, switched to sdk 1.15.14, which has post with keep alive option
|
Deploying meet-web with
|
| Latest commit: | 51dc483 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://796f23b7.meet-web.pages.dev |
| Updated (Europe/Madrid): | 7/5/2026, 18:21:18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the participant does a page reload, the count of users inside the room becomes incorrect (shows more users than the actual participants inside the room). Seems to be because the server doesn't receive the leaveCall request. Also, there were zombies because
beforeunloadwas stopping normal Jitsi disconnect events and never re-sending them afterwards.Ideally, front and server need to do ping-pong, keepalive, or similar, so front doesn't have to notify the server.
As a temporary fix, after the user confirms the intent to leave, the browser will manually send a leaveCall request. Has to be done manually with fetch because otherwise, browser reload will kill the request mid-process with NS_BINDING_ABORTED, and the server will never process it.
As for beforeunload, I tried to keep it, but it's harder than I thought.
Checklist
How Has This Been Tested?
Additional Notes