Skip to content

[MKT-842]:feat/add default fallback for non special plans#1950

Open
jaaaaavier wants to merge 2 commits intomasterfrom
feat/add-fallback-for-simple-plans
Open

[MKT-842]:feat/add default fallback for non special plans#1950
jaaaaavier wants to merge 2 commits intomasterfrom
feat/add-fallback-for-simple-plans

Conversation

@jaaaaavier
Copy link
Copy Markdown
Contributor

@jaaaaavier jaaaaavier commented May 7, 2026

Description

In this PR, we resolved an issue related to the plans we offer that aren’t displayed on the website and are used for other purposes. The point is that these plans have their own IDs and could appear at checkout, so they must be accounted for. Previously, we assumed that if a plan wasn’t one of the three we have on website, it would be the free plan and we used the 1GB path, this is no longer the case. To address this:

  • We have modified the JSONs so that it is no longer the 1GB plan but the default one, we dynamically pass the size in bytes to this JSON
  • We’ve also updated the checkoutProductCard so it can recognize when a plan has specific features (Array.isArray—this is done because if that’s not the case, it literally returns the path) or should use the default features. The approach for the title is the same

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

We have verified that the standard plans continue to display as expected and that these special plans are now being displayed. Examples:

  • planId=price_1RjEJPFAOdcgaBMQifUoiJgL
  • planId=price_1RBxrfFAOdcgaBMQxbEQlLsI

Additional Notes

@jaaaaavier jaaaaavier marked this pull request as ready for review May 7, 2026 15:16
@jaaaaavier jaaaaavier marked this pull request as draft May 7, 2026 15:17
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 7, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f1624d
Status: ✅  Deploy successful!
Preview URL: https://0d6a65d1.drive-web.pages.dev
Branch Preview URL: https://feat-add-fallback-for-simple.drive-web.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f1624d
Status:⚡️  Build in progress...

View logs

@jaaaaavier jaaaaavier self-assigned this May 7, 2026
@jaaaaavier jaaaaavier added the enhancement New feature or request label May 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@jaaaaavier jaaaaavier marked this pull request as ready for review May 7, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant