[PB-6362] feature/Impove cloud sync timeline synchronisation#443
Open
CandelR wants to merge 2 commits intofeature/PB-6362-cloud-syncfrom
Open
[PB-6362] feature/Impove cloud sync timeline synchronisation#443CandelR wants to merge 2 commits intofeature/PB-6362-cloud-syncfrom
CandelR wants to merge 2 commits intofeature/PB-6362-cloud-syncfrom
Conversation
…proved cloud history sync and fix local asset eager loading in Photos timeline
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors cloud history sync and Photos timeline hooks for correctness and performance.
Summary
PhotoCloudBrowser.syncAllHistory: replaces the sequential month iteration. Now load all history fetching drive folders.usePhotosTimelinesplit: extracted intouseLocalAssets(MediaLibrary pagination) and useCloudAssets (database cloud items) for independent reactivity.useLocalAssetsloads allMediaLibrarypages in the background immediately after mount instead of waiting foronEndReached. Fixes a bug wherecloud-onlyitems from other devices appeared before local assets had finished paginating.mergeCloudIntoGroups: refactored to preserve reference equality for groups with no cloud additions, soFlashListskips reconciliation for unchanged cells.LocalPhotoCell: adds a custom memo comparator and key={item.id} on Image to prevent the previous photo from flashing when a cell is recycled.