feat: update drive destkop linux to electron 29 and node 20#332
Merged
AlexisMora merged 2 commits intofeat/go-fuse-daemonfrom May 8, 2026
Merged
feat: update drive destkop linux to electron 29 and node 20#332AlexisMora merged 2 commits intofeat/go-fuse-daemonfrom
AlexisMora merged 2 commits intofeat/go-fuse-daemonfrom
Conversation
|
AlexisMora
commented
May 8, 2026
| @@ -1,4 +1,4 @@ | |||
| const electronRebuild = require('electron-rebuild'); | |||
| const electronRebuild = require('@electron/rebuild'); | |||
Author
There was a problem hiding this comment.
This got changed because i saw that the dependency electron-rebuild got deprecated in favor of this new one, and they also state that there is not api change, just package name
egalvis27
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed
Electron 29 runs on Node 20, and
start:mainwas passingsrc/apps/main/main.tsdirectly to Electron.With Electron 29 Node runtime, the entrypoint is resolved through Node ESM loader path. Node does not execute
.tsfiles natively, and the ESM loader does not use the CommonJS hook installed byts-node/register.I have added a small .js script that allows electron to load the
start-main-dev.jsfirst, then the script registersts-node, thenrequire()smain.ts. At that point the CommonJS require hook can compile TypeScript on demand.