ci: add --fail to curl and remove -f from rm to prevent silent CI failures#300
ci: add --fail to curl and remove -f from rm to prevent silent CI failures#300Wenzel merged 1 commit intointel:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to avoid “successful” runs when external downloads fail, by making curl error out on HTTP failures and making cleanup steps fail if expected artifacts are missing.
Changes:
- Add
--failto SIMICS dependency downloadcurlcommands. - Remove
-ffrom anrmcommand so missing files are surfaced as CI errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| curl --fail --noproxy -L -o "${HOME}/simics/ispm.tar.gz" \ | ||
| "${{ env.PUBLIC_SIMICS_ISPM_URL }}" && \ | ||
| curl --noproxy -L -o "${HOME}/simics/simics.ispm" \ | ||
| curl --fail --noproxy -L -o "${HOME}/simics/simics.ispm" \ |
There was a problem hiding this comment.
curl --noproxy requires an argument (e.g., '*' or a comma-separated host list). As written, -L is being consumed as the --noproxy value, so redirects may not be followed and proxy-bypass behavior is unintended. Pass an explicit value to --noproxy (or remove it if not needed) so -L is parsed correctly.
…from rm to prevent silent CI failures
Wenzel
force-pushed
the
fix/ci-curl-fail-and-rm
branch
from
27c46c7 to
ce5fb4a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.