Repository navigation
docs: add a rule for how tests in this repo are written - #54
Conversation
|
In overall, please, make it more human-readable |
Signed-off-by: Łukasz Ślusarczyk <lukasz.slusarczyk@intel.com>
A wrong test does not write a product bug. Examples catch the specific error type. The torch.compile patch example mocked a library the rule forbids, so it is gone. Signed-off-by: Łukasz Ślusarczyk <lukasz.slusarczyk@intel.com>
Say the same rules in full sentences. Keep them short. Signed-off-by: Łukasz Ślusarczyk <lukasz.slusarczyk@intel.com>
bc8e661 to
4245f9f
Compare
Done in the second commit. The first applies your comments. The second makes everything more human readable. |
|
I would describe additionally:
|
Skip and xfail require a reason. New files are test_<behavior>.py. Signed-off-by: Łukasz Ślusarczyk <lukasz.slusarczyk@intel.com>
Applied two first points.
A new file is
A coverage percentage are not in this rule. The repo does not measure coverage yet. |
A round trip is save, load, and forward. One behavior does not mean one call. Signed-off-by: Łukasz Ślusarczyk <lukasz.slusarczyk@intel.com>
The rule tells developers and agents to keep them dumb, specific, and tied to behavior.
It loads when a file under
tests/orconftest.pyis in context.