[SYCL] Fix TCAndArchs leaking across offload kinds in BuildOffloadingActions#22463
Open
wenju-he wants to merge 1 commit into
Open
[SYCL] Fix TCAndArchs leaking across offload kinds in BuildOffloadingActions#22463wenju-he wants to merge 1 commit into
wenju-he wants to merge 1 commit into
Conversation
…Actions TCAndArchs was declared outside the per-kind loop but only cleared inside it after the bug was introduced by ccdf2c6. Without the clear, entries from prior kinds (e.g. OpenMP's spir64 TC) accumulated and were incorrectly used when processing subsequent kinds (SYCL), causing SYCL device actions to pick up the wrong toolchain triple. CMPLRLLVM-76332 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCAndArchs was declared outside the per-kind loop but only cleared inside it after the bug was introduced by ccdf2c6. Without the clear, entries from prior kinds (e.g. OpenMP's spir64 TC) accumulated and were incorrectly used when processing subsequent kinds (SYCL), causing SYCL device actions to pick up the wrong toolchain triple.
CMPLRLLVM-76332