Skip to content

[SYCL] Include iostream in sycl.hpp to avoid compile time errors #22458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koparasy wants to merge 1 commit into
base: sycl
Choose a base branch
from
+11 −0
Open

[SYCL] Include iostream in sycl.hpp to avoid compile time errors #22458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sycl/include/sycl/sycl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ can be disabled by setting SYCL_DISABLE_FSYCL_SYCLHPP_WARNING macro.")
#undef __SYCL_TOSTRING
#undef __SYCL_STRINGIFY

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
// OV team requires sycl headers to be iostream-free, SYCL is
// not a iostream "provider", however we used to include iostream in some of our
// transitive headers. Customers relied on that inclusion, so we need to keep it
// for now. This is a temporary solution, and we should remove this block once
// breaking changes are allowed. OV team accesses SYCL functionality through the
// split-header khr, so they are not pulling sycl.hpp. So this is a temporary
// solution for the past customers that relied on iostream.
Comment on lines +36 to +42

@dm-vodopyanov dm-vodopyanov Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to improve wording in the main public header, something like:

<sycl/sycl.hpp> is not a iostream "provider", however iostream was included in some of SYCL transitive headers. Customers relied on that inclusion, so it should be kept for now and be removed once breaking changes are allowed.

#include <iostream>
#endif

// All SYCL macro are provided through this header
#include <sycl/khr/split_headers/version.hpp>

Expand Down
Loading