Skip to content

[SYCL] Add removal guard for info::device::atomic64 use-cases #22456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robertkq wants to merge 1 commit into
base: sycl
Choose a base branch
from
+7 −0
Open

[SYCL] Add removal guard for info::device::atomic64 use-cases #22456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sycl/include/sycl/info/device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,13 @@ struct __SYCL2020_DEPRECATED("deprecated in SYCL 2020, use "
};

// Extensions/deprecated
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
struct __SYCL_DEPRECATED("use sycl::aspect::atomic64 instead") atomic64
: device_traits<UR_DEVICE_INFO_ATOMIC_64> {
using return_type = bool;
};
#endif

struct reference_count : device_traits<UR_DEVICE_INFO_REFERENCE_COUNT> {
using return_type = uint32_t;
};
Expand Down
2 changes: 2 additions & 0 deletions sycl/source/detail/device_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,9 @@ class device_impl {
CASE(int64_extended_atomics) {
return has_extension("cl_khr_int64_extended_atomics");
}
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
CASE(atomic64) { return get_info<info::device::atomic64>(); }
#endif
CASE(image) { return get_info<info::device::image_support>(); }
CASE(online_compiler) {
return get_info<info::device::is_compiler_available>();
Expand Down
2 changes: 2 additions & 0 deletions sycl/source/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,9 @@ __SYCL_DEVICE_INFO_INST(partition_affinity_domains,
__SYCL_DEVICE_INFO_INST(partition_type_property, info::partition_property)
__SYCL_DEVICE_INFO_INST(partition_type_affinity_domain,
info::partition_affinity_domain)
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
__SYCL_DEVICE_INFO_INST(atomic64, bool)
#endif
__SYCL_DEVICE_INFO_INST(reference_count, uint32_t)
__SYCL_DEVICE_INFO_INST(usm_device_allocations, bool)
__SYCL_DEVICE_INFO_INST(usm_host_allocations, bool)
Expand Down