Skip to content

[SYCL] Fix skipped check for device_global property in SYCLPostLink #22402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maksimsab wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Fix skipped check for device_global property in SYCLPostLink #22402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0916848
[SYCL] Fix skipped check for device_global property in SYCLPostLink
maksimsab Jun 23, 2026
d6b215a
Update ComputeModuleRuntimeInfo.cpp
maksimsab Jun 24, 2026
e5557f2
Update ComputeModuleRuntimeInfo.cpp
maksimsab Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions llvm/lib/SYCLPostLink/ComputeModuleRuntimeInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,13 @@ PropSetRegTy computeModuleProperties(const Module &M,
if (!GV.hasExternalLinkage())
continue;

auto *ST = dyn_cast<StructType>(GV.getValueType());
if (!ST || ST->isLiteral()) // Literal structs don't have names.

@sarnex sarnex Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead would calling hasName() work? just in case there is another case there is no name

@YuriPlyakhin YuriPlyakhin Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
Also I would update the comment to: // Only named structs carry the device_global type name.

continue;

// Check if it's a device_global by type name (declarations don't have
// attributes).
std::string TypeName;
raw_string_ostream(TypeName) << *GV.getValueType();

StringRef TypeName = ST->getStructName();
if (TypeName.find("device_global") == std::string::npos)
continue;

Expand Down
Loading