Skip to content

ice: kcompat: only backport netdev_xmit_more() when kernel lacks it #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomeoLLee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ice: kcompat: only backport netdev_xmit_more() when kernel lacks it #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/kcompat-generator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ function gen-netdevice() {
gen HAVE_RHEL7_NETDEV_OPS_EXT_NDO_SETUP_TC if method ndo_setup_tc_rh of net_device_ops_extended in "$ndh"
gen HAVE_SET_NETDEV_DEVLINK_PORT if macro SET_NETDEV_DEVLINK_PORT in "$ndh"
gen NEED_NETDEV_TX_SENT_QUEUE if fun __netdev_tx_sent_queue absent in "$ndh"
gen NEED_NETDEV_XMIT_MORE if fun netdev_xmit_more absent in "$ndh"
gen NEED_NETIF_NAPI_ADD_NO_WEIGHT if fun netif_napi_add matches 'int weight' in "$ndh"
gen NEED_NET_PREFETCH if fun net_prefetch absent in "$ndh"
gen NEED_XDP_FEATURES if enum netdev_xdp_act absent in include/uapi/linux/netdev.h
Expand Down
2 changes: 2 additions & 0 deletions src/kcompat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2979,12 +2979,14 @@ _kc_dev_change_flags(struct net_device *netdev, unsigned int flags,

/*****************************************************************************/
#if (LINUX_VERSION_CODE < KERNEL_VERSION(5,2,0))
#ifdef NEED_NETDEV_XMIT_MORE
#if (defined HAVE_SKB_XMIT_MORE) && \
(!(RHEL_RELEASE_CODE && (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(8,2))))
#define netdev_xmit_more() (skb->xmit_more)
#else
#define netdev_xmit_more() (0)
#endif
#endif /* NEED_NETDEV_XMIT_MORE */

#ifndef mmiowb
#ifdef CONFIG_IA64
Expand Down