Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Changed

- **ruff now flags a stale `# noqa`** — RUF100 is selected, and the four `# noqa: F401` comments that silenced
nothing are removed. Codes of rules dokimi does not select (BLE001, E402, E731 and a few more) are listed in
`lint.external`, so their `noqa` comments stay. No runtime change.
2 changes: 1 addition & 1 deletion dokimi/dokimi/eval/arm_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from typing import Any, Dict, List, Optional, Sequence

from dokimi.caching import is_empty_reply
from dokimi.utils import question_id # noqa: F401 (re-exported: callers import it from here)
from dokimi.utils import question_id # re-exported: callers import it from here
from dokimi.artifacts import save_artifact
from dokimi.llm import llm_call_with_usage
from dokimi.defaults import DEFAULT_ANSWER_MODEL, DEFAULT_ANSWER_PROVIDER
Expand Down
2 changes: 1 addition & 1 deletion dokimi/dokimi/harnesses/container_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

from dokimi import docker_cmd, process
from dokimi.docker_cmd import TASK_CONTAINER_HARDENING, Docker # noqa: F401 (Docker is re-exported)
from dokimi.docker_cmd import STEP_TIMEOUT_S as DOCKER_STEP_TIMEOUT # noqa: F401
from dokimi.docker_cmd import STEP_TIMEOUT_S as DOCKER_STEP_TIMEOUT

from . import egress_proxy
from .agent_sandbox import (
Expand Down
2 changes: 1 addition & 1 deletion dokimi/dokimi/harnesses/docker_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
resolve_recorded, skill_needs, start_args, redact as _redact)
from .skill_treatment import Treatment, build_plugin, check_skill, skill_listing, treatment_notice
from .solver_stream import record_solver, run_solver
from .task_env import _exec_env, unresolved_env # noqa: F401 (re-exported)
from .task_env import _exec_env, unresolved_env # re-exported
from .tbench_v1 import reward as _pytest_reward
from .tasks import ( # noqa: F401 (timeouts re-exported)
_DEFAULT_BUILD_TIMEOUT,
Expand Down
2 changes: 1 addition & 1 deletion dokimi/dokimi/mcp/mcp_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
def _require_mcp():
"""Import the optional ``mcp`` SDK or raise a helpful error."""
try:
import mcp # noqa: F401
import mcp
return mcp
except ImportError as exc: # pragma: no cover - exercised via tests with monkeypatch
raise MCPConnectionError(
Expand Down
6 changes: 3 additions & 3 deletions dokimi/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ extend-exclude = ["benchmarks", "data", "tests/fixtures/task_formats"]
# files above for 3.11:
# UP (pyupgrade) 1399, of which PEP 585/604 annotations 1185, imports 162
# I (isort) 156
# RUF100 (unused noqa) 22: most name rules not selected (BLE001, E402), so
# select those or list them in lint.external first
# Hand fixes deferred because an open PR rewrites the same lines (#29, one
# process runner for the spawn sites):
# PLW1509 (preexec_fn with threads) 1, PLW1510 (subprocess.run without
Expand Down Expand Up @@ -226,8 +224,10 @@ select = [
"RUF006", "RUF008", "RUF009", "RUF013", "RUF016", "RUF017", "RUF018",
"RUF020", "RUF024", "RUF026", "RUF028", "RUF030", "RUF032", "RUF033", "RUF034",
"RUF040", "RUF048", "RUF049", "RUF053", "RUF060", "RUF061", "RUF063", "RUF064",
"RUF068", "RUF071", "RUF101", "RUF102", "RUF103", "RUF104", "RUF200",
"RUF068", "RUF071", "RUF100", "RUF101", "RUF102", "RUF103", "RUF104", "RUF200",
]
# noqa codes of rules not selected here; RUF100 leaves them alone.
external = ["ARG001", "BLE001", "E402", "E731", "N802", "N818", "S310"]
ignore = [
"A002", # argument named like a builtin: keyword APIs mirror subprocess's input=
"G004", # f-string in a logging call: style, 108 sites
Expand Down
Loading