Skip to content

novelty atoms reader accepts an atoms file with status: partial and no partial block #642

Closed

Description

@antonwolfy

load_atoms_record (dokimi/dokimi/novelty/atoms.py:787) refuses a partial atoms file only when the partial key is present. A file with "status": "partial" and no partial block is read as a finished atom set. Repro: write {"schema_version": "novelty-atoms.v1", "status": "partial"} and call load_atoms_record(path): it returns ([], [], {...}) instead of raising InputError. Fix: also refuse data.get("status") == "partial", as load_artifact does for novelty.json since #633.

Follow-up from the review of #633: #633 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions