Always collect templates for indexing, even if not at toplevel#206
Open
JonatanWaern wants to merge 1 commit intomainfrom
Open
Always collect templates for indexing, even if not at toplevel#206JonatanWaern wants to merge 1 commit intomainfrom
JonatanWaern wants to merge 1 commit intomainfrom
Conversation
14604b1 to
fe0dba3
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure template declarations are collected for indexing even when they appear in non-toplevel (invalid) contexts, improving resilience and editor feedback in broken-syntax scenarios.
Changes:
- Move template tracking into
StatementSpecand add recursivegather_templates()to collect templates from nested statement specs. - Track templates encountered in invalid contexts during hash-if flattening (while still emitting an error).
- Rename
from_device_and_basestotemplates_from_device_and_basesand update changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/analysis/structure/toplevel.rs | Adds templates to StatementSpec, tracks templates during flattening, and provides recursive template gathering. |
| src/analysis/structure/objects.rs | Adjusts scope collection to include template scopes from statement lists. |
| src/analysis/mod.rs | Renames and updates template collection helper to use TopLevel::gather_templates(). |
| CHANGELOG.md | Documents the improved indexing behavior for templates in invalid contexts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fe0dba3 to
9cca5ab
Compare
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
9cca5ab to
165d00b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonatan Waern jonatan.waern@intel.com