Remove nothrow and data from the 1.4 grammar#425
Remove nothrow and data from the 1.4 grammar#425mandolaerik wants to merge 3 commits intointel:mainfrom
nothrow and data from the 1.4 grammar#425Conversation
|
urgh, I get a failure if I apply this: |
8d00094 to
69eab79
Compare
|
Never mind, |
|
PR Verification: ✅ success |
| keywords_dml12[kw] = kw.upper() | ||
| tokens += (kw.upper(),) | ||
| reserved_idents = reserved_idents_common + (kw.upper(),) | ||
| reserved_idents = reserved_idents + (kw.upper(),) |
There was a problem hiding this comment.
wait so the old code failed to properly have PARAMETER as part of reserved_idents? That's hilarious. Given how DML 1.2 code has clearly adapted to this, I'd vote for keeping parameter restricted.
There was a problem hiding this comment.
I vote against that because it complicates code for no gain. The gain of keeping it reserved is to open for extending syntax in some ways, like allowing parameter declarations inside methods, and if we ever will want to do that kind of change, then it will be 1.4 exclusive.
69eab79 to
0651354
Compare
|
PR Verification: ✅ success |
No description provided.