Add dml-breaking-changes file to be used by cmake#407
Open
mandolaerik wants to merge 1 commit intointel:mainfrom
Open
Add dml-breaking-changes file to be used by cmake#407mandolaerik wants to merge 1 commit intointel:mainfrom
mandolaerik wants to merge 1 commit intointel:mainfrom
Conversation
Contributor
Author
mandolaerik
force-pushed
the
pr/add-dml-breaking-changes-file-to-be-used-by-cmake
branch
from
810f1b3 to
c4dd60b
Compare
mandolaerik
force-pushed
the
pr/add-dml-breaking-changes-file-to-be-used-by-cmake
branch
from
c4dd60b to
843ab45
Compare
mandolaerik
force-pushed
the
pr/add-dml-breaking-changes-file-to-be-used-by-cmake
branch
2 times, most recently
from
4d93f3c to
99b8d3f
Compare
mandolaerik
requested review from
jhbaarnh and
lwaern-intel
and removed request for
lwaern-intel
lwaern-intel
reviewed
Mar 5, 2026
| vect-needs-provisional: | ||
| opt-in: [4, 5, 6, 7] | ||
| forbid-warning-statement: | ||
| opt-in: [4, 5, 6, 7] |
Contributor
There was a problem hiding this comment.
Feels like we'd wanna autogen this based on the classes of breaking-change.py.
test/tests.py
Outdated
| set(changes_in_cmake) - set(changes_in_dmlc))) | ||
| self.pr(f"changes only in breaking_changes.py: " + str( | ||
| set(changes_in_dmlc) - set(changes_in_cmake))) | ||
| raise TestFail(f'mismatch') |
Contributor
There was a problem hiding this comment.
... Especially since then that'd make this test redundant. My gut feeling is that the complexity cost of autogenning the file would be comparable to the complexity cost of this test.
Contributor
Author
There was a problem hiding this comment.
The reason for explicit yaml is that cmake needs the file, before dmlc has been built.
I realized that a better approach is to instead move all info to yaml, and let breaking_changes.py read the file as a module resource. Done now.
This allows the file to be consumed by cmake
mandolaerik
force-pushed
the
pr/add-dml-breaking-changes-file-to-be-used-by-cmake
branch
from
99b8d3f to
737a22a
Compare
Contributor
Author
Contributor
|
PR Verification: ❌ failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.